From: Thomas Gleixner <tglx@linutronix.de>
To: Guillaume La Roque <glaroque@baylibre.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Nishanth Menon <nm@ti.com>,
Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, vishalm@ti.com,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Guillaume La Roque <glaroque@baylibre.com>,
Nicolas Frayer <nfrayer@baylibre.com>
Subject: Re: [PATCH v3 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver
Date: Wed, 16 Oct 2024 18:38:07 +0200 [thread overview]
Message-ID: <875xpsatqo.ffs@tglx> (raw)
In-Reply-To: <20241016-timodules-v3-1-fa71091ade98@baylibre.com>
On Wed, Oct 16 2024 at 11:41, Guillaume La Roque wrote:
> From: Nicolas Frayer <nfrayer@baylibre.com>
irqchip: Kconfig: is not a valid prefix.
This is about the TI SCI router, so this wants to use the
irqchip/ti-whatever prefix.
>
> Added module build support in Kconfig for the TI SCI interrupt router
> driver
Added?
This wants to be 'Add ...'
You fail to explain why it is valid to build this as a module, i.e. you
did the analysis that there is no dependency on this before modules can
be loaded.
> MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ticom>");
> MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol");
> +MODULE_LICENSE("GPL");
This change is not mentioned in the change log.
Thanks,
tglx
next prev parent reply other threads:[~2024-10-16 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 9:41 [PATCH v3 0/2] irqchip: Kconfig: Add module support for TI inta/intr Guillaume La Roque
2024-10-16 9:41 ` [PATCH v3 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver Guillaume La Roque
2024-10-16 13:37 ` Andrew Davis
2024-10-16 14:18 ` Guillaume LA ROQUE
2024-10-16 14:26 ` Andrew Davis
2024-10-16 16:38 ` Thomas Gleixner [this message]
2024-10-16 18:32 ` Guillaume LA ROQUE
2024-10-16 9:41 ` [PATCH v3 2/2] irqchip: Kconfig: Added module build support for the TI interrupt aggregator Guillaume La Roque
2024-10-16 13:48 ` Andrew Davis
2024-10-18 8:01 ` Guillaume LA ROQUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xpsatqo.ffs@tglx \
--to=tglx@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=glaroque@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkorpershoek@baylibre.com \
--cc=nfrayer@baylibre.com \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=vishalm@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).