From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C49BCF6D28 for ; Wed, 2 Oct 2024 13:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=whXTKWEOMAgeGAS9876qMUwkTE6aY26TEx5jZc2uCyE=; b=KnP2jRWSu+v1QEnZs1KMsgZxZU gOc56W9Wih+JMuB2yXe0yf9c0nXVRm9NAe6RG9FXo9iys9nO3FlXjxeI/Lgc9w1itXEYAelCQN8ht 71TQ9eE4tsdpflSB3na9Na6qKPtr22kE0zvkDybBoqrB3MmuQUHzw6Zdjl39NPjarIOcRrXu75ehd o/J4mkWZwXhgpNbfhqL5kdMF62aqr2zVmyWulSxsR3rgEx+xL5nQuHSg3U1bVQGbRsIsG6iw/2YC5 F+5nNPn+Vhy2VqK8JWP1RgBF9Q/37QR4SfW9zo/T3tQ4wB4EZ1gO/VgguvgAtpCjKYh++JzCi9ldO QRKdjkhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svzeg-00000006C8s-3yqC; Wed, 02 Oct 2024 13:44:38 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svzdM-00000006Bec-39Fc for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 13:43:19 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1727876593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=whXTKWEOMAgeGAS9876qMUwkTE6aY26TEx5jZc2uCyE=; b=YJ4PCkKNbfvfP2++jy8vdMs6by125YjjILEaRFd0RVq5Rj2wFwx7jueEMoUVCQjcedtjfK NvkNgyvx5k6WBj3OJj8A3iVMpBe/UR4J6UWP0v5EHpK8jzEEBUyPzAc73b9jnTtpHaIPFx lAOO7hJZjACwkJVb3cQxr3UFtIq9x7ccz0S+RrgrIL+siOz6O9aQgfAwbwMu+ZucMvalh4 6qWXSKzPv4mx9QCfHU2sbrtwljRprU4kUAcFfMrFBLkK4GlF6M81jNoTaYPMjsD7HOwxKT cKHZmRqGIPYdPGqmUaW2OqWzS8yvbE7XXcuN1oLJybMZoxjmfsx2lTH3J9DT5Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1727876593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=whXTKWEOMAgeGAS9876qMUwkTE6aY26TEx5jZc2uCyE=; b=0GgIhnxgfhcfTcN3aKWtZQE8UdWJyzvGgrZPc3volSOmQZhmKypRfEHSpO3kJ+buVx1NAq liAGqYl0L5MCoBCw== To: Michael Kelley , Steven Price , Marc Zyngier Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Will Deacon , Suzuki K Poulose Subject: RE: [PATCH 1/2] irqchip/gic-v3-its: Share ITS tables with a non-trusted hypervisor In-Reply-To: References: <20240905091738.28544-1-steven.price@arm.com> <20240905091738.28544-2-steven.price@arm.com> Date: Wed, 02 Oct 2024 15:43:13 +0200 Message-ID: <875xqay61a.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_064316_950946_352FCAF9 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 09 2024 at 03:47, Michael Kelley wrote: >> + ret = set_memory_decrypted((unsigned long)page_address(page), >> + 1 << order); >> + if (WARN_ON(ret)) > > On the x86 side, the WARN is done in the implementation of > set_memory_decrypted()/encrypted() so that each call site doesn't > need to do the WARN. Each call site must only leak the memory > if the return value indicates other than success. There are call sites > in architecture neutral code (such as for swiotlb and DMA direct) > that expect the WARN is in set_memory_decrypted()/encrypted(). > To recap a previous discussion, we want the WARN for notification, > but also so the most security-conscious users can set > kernel.panic_on_warn=1 to stop further processing if there are > problems in the decryption/encryption operation. What's the resolution of this? Thanks, tglx