From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B476CC3DA4A for ; Thu, 1 Aug 2024 08:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Syi3zSlJ8k1vqxBzUq6nZD+avtMgHQU+/NZ7B5gDmQ4=; b=agz+0220Pwb5B3IOAbl5B6dyBr DsGtcvKb+nQJSaLowcttNiu9wmnJItQ6fG2kK/hZJSiceMssMcHwkwRXdrGVY9WUrSCHoCQbU7JyH zYXllRLufcZyMtvEA6uUE8m+cGZw5DRKCECPPdFqJjdB0Qh3+EWMecyk10yLRQ0Wq3rCMby+vmoWb A4OCRGa/L4aH17WduQsTp6Up11I2L1ICpj7o/kpnf6jGgE0IsjFS3gCsuoLSyl3fILDgeL6dLnDzm ke3XmdNwjrovXb11ewsAfJcKjxPcqUbxPLcUMq0gdGiCKJ9nUvHl/yExjfgp2aRyYfAzMjHFkAOCA 1baJ/XoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZReF-00000004RmB-3fh9; Thu, 01 Aug 2024 08:58:59 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZRco-00000004RQl-1DqF for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 08:57:48 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a7a8e73b29cso552246066b.3 for ; Thu, 01 Aug 2024 01:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722502649; x=1723107449; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Syi3zSlJ8k1vqxBzUq6nZD+avtMgHQU+/NZ7B5gDmQ4=; b=aAGEBadaymA72olGvPJRub6hK8usZQ33nCX0ZsvuSt44H+66yn16t5JZz4icu6ZEMb TrUiYwb0r1NJoc8vpRJA5I3GM9KsEsDIbxUTNSyur5BB1P6vAhdU4pZb8/8qyiEoJcYb MzalYJ69mkmrK7ZPvp7nOnaBOSPAXJw3eGVaIejd6Zl8wJpyXy8n+FZmAOgALjFu4dWA oAGALLi5xGo6A2kFG+3kgR6Bv7QkR+RrkEBrdDTVSyhMFtJ8wqDqRfpuWFcrcWR/Tg8C ZTCseNr+ZDOs0B9sk/B/KI8xKQvNB9MzSX67rwb+ZvCM2a8uYz1o1Aghafu7gReGOBzA fgEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722502649; x=1723107449; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Syi3zSlJ8k1vqxBzUq6nZD+avtMgHQU+/NZ7B5gDmQ4=; b=mjYCpoENg2qp2I3Yyr90ai2kL76ee0yDSXLG+mZxbdGTG5MOqGhZ6P++5An/Qu6CKY kMtGJ1XcBIKXGaFs8IApA5eR2agB4g/CelqI8r/62sdLHvlQGJfwrbCLycx27krX5Wbe YU+OTrV4AL4fR61M7gAY2gjdSvgKAWFWY8oCz0GTq7WDsuH4//GwTe0c7wCe1ynS7N66 cgvMgQfjgMNywFNQ1ZFfH7RR6gNzFV5RI/+gGByDwZ/nejvh6fVDxDev4sVw2eosPLiE A/n4hUXFlIPCnNNtMUNTO8qBKLpH9dt6SPr886Voti8IgHK78OXP6NinSkRyuBx6rbSj 0xUA== X-Forwarded-Encrypted: i=1; AJvYcCUiN004iNtngZ63x+wg5xPS3JVjI7pgP8Uw/q4qZsvbWbtKvY21Lz09E+BZsYLvq2F57ET0oHn1gwuWTYBWB2LTLpbP8oWcepjbjJHyikFFzRyTnh4= X-Gm-Message-State: AOJu0YyASbz7op2129sYsWwBTMED6L0cAp2cp8dpZgPuC5TIY7dbz8Ag eaRR+3An3FfAG1nKKDTt4KnU5wwRD4vwQlzvXtPAkI8jo9coz3qSx40FKuE79YY= X-Google-Smtp-Source: AGHT+IEdS3NM6t6Y7T/95sEL4C7ubpn/6F0Cu3mCtANczyd9mmWSLE4tcyyhWaOoIZKPq4CsXdarWQ== X-Received: by 2002:a17:907:6d0e:b0:a75:1069:5b94 with SMTP id a640c23a62f3a-a7daf535320mr136914966b.21.1722502647807; Thu, 01 Aug 2024 01:57:27 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acadb82d5sm865337466b.199.2024.08.01.01.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 01:57:27 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3FE7E5F80C; Thu, 1 Aug 2024 09:57:26 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 03/84] KVM: Drop KVM_ERR_PTR_BAD_PAGE and instead return NULL to indicate an error In-Reply-To: <20240726235234.228822-4-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:12 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-4-seanjc@google.com> Date: Thu, 01 Aug 2024 09:57:26 +0100 Message-ID: <875xskfwnd.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_015730_353140_4E995FD6 X-CRM114-Status: UNSURE ( 9.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sean Christopherson writes: > Remove KVM_ERR_PTR_BAD_PAGE and instead return NULL, as "bad page" is just > a leftover bit of weirdness from days of old when KVM stuffed a "bad" page > into the guest instead of actually handling missing pages. See commit > cea7bb21280e ("KVM: MMU: Make gfn_to_page() always safe"). > > Signed-off-by: Sean Christopherson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro