From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: "Heiner Kallweit" <hkallweit1@gmail.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivami" <manivannan.sadhasivam@linaro.org>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-actions@lists.infradead.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2] ath9k: use unmanaged PCI functions in ath9k_pci_owl_loader
Date: Tue, 30 Jul 2024 11:59:50 +0200 [thread overview]
Message-ID: <875xsnp5d5.fsf@toke.dk> (raw)
In-Reply-To: <3b46f6c7-4372-4cc9-9a7c-2c1c06d29324@gmail.com>
Heiner Kallweit <hkallweit1@gmail.com> writes:
> Only managed PCI resource in the driver is the iomapped bar. However the bar
> is unmapped in the same function. Therefore using the device-managed
> versions just causes overhead, w/o any benefit. Once this is switched to the
> non-managed versions, there's nothing left to be managed for
> pcim_enable_device(). Therefore we can reduce overhead here too and switch to
> the non-managed version as well. This includes removing the no longer needed
> call to pcim_pin_device().
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
next prev parent reply other threads:[~2024-07-30 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 20:28 [PATCH v2] ath9k: use unmanaged PCI functions in ath9k_pci_owl_loader Heiner Kallweit
2024-07-30 9:59 ` Toke Høiland-Jørgensen [this message]
2024-08-01 14:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xsnp5d5.fsf@toke.dk \
--to=toke@toke.dk \
--cc=afaerber@suse.de \
--cc=hkallweit1@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).