From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6879C3DA49 for ; Tue, 30 Jul 2024 10:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VKVnO8jReJ4Bgh4LNYlqBwyBLVhtI+mxGjxwPRV7z8c=; b=xd62JDE5pscfqJyCIQrCZnNYqj HgdfyLmeUU0h7LpK4vQlX99BBtK8JDmUP7PJejj+eaow7o05hmADnFTL4t3AzAsf2Wa/nlUo2i9Oh vYdk42wDNbgQPlTWGZnxoxyCNDrzfHjLa5e2wG8tbfW9NKstmreDuzC9HKkkzQ9dCuSS2DPRarPc2 wyais5AxmkblykzkUJvlymJuD/MkG7gjOici2WpCYm7xWm1GbLisA9t6QWcdFo0EZE/MHcsIEvlFa hMxmSKhCqfTeXK1V9TaFEzPPMAPU+Cidmiaet6k7+clQ0XDyszJcAHXqNhPYOZuZ0KVy3vl3kzgC+ Y+QvDLpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYjev-0000000Ee4Q-2ZqC; Tue, 30 Jul 2024 10:00:45 +0000 Received: from mail.toke.dk ([2a0c:4d80:42:2001::664]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYjeO-0000000EdqE-3fOV; Tue, 30 Jul 2024 10:00:16 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1722333605; bh=VKVnO8jReJ4Bgh4LNYlqBwyBLVhtI+mxGjxwPRV7z8c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cFSTqbwbOGllqs/C6AyhNmJUNT8fIJHbdOndiuH51F2686RUEmCZA6gHtFjKxBGDb IY/iWUJjX+nc+CifkSvqMhjjmblcnY3jVahrkmYpAs0LrqKuJvwZBlM5GJ4xF/lANo ub9HkkIw/O3jrtgtT6rQaVFcqyqm9Dw5oM9V9eVInb73ZyA5GTz+XP4blXTSSV/qTv S62I5f4V0euyKGFzVlB8ixctYuXGCOXk6njbzTPOgKmTeLqVsBQdoftXTBe7xamPV+ RmXchCtPTrmIofgvjfPhRcMZ9hM8X2Jc/eGW1pSn3IbbHJB/BZDP/D7An47yKG0w92 YNodZsFf1FV5A== To: Heiner Kallweit , Kalle Valo , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivami , Martin Blumenstingl Cc: linux-wireless , "linux-arm-kernel@lists.infradead.org" , linux-actions@lists.infradead.org, "linux-pci@vger.kernel.org" Subject: Re: [PATCH v2] ath9k: use unmanaged PCI functions in ath9k_pci_owl_loader In-Reply-To: <3b46f6c7-4372-4cc9-9a7c-2c1c06d29324@gmail.com> References: <3b46f6c7-4372-4cc9-9a7c-2c1c06d29324@gmail.com> Date: Tue, 30 Jul 2024 11:59:50 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <875xsnp5d5.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_030013_513497_72D86DF7 X-CRM114-Status: UNSURE ( 7.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Heiner Kallweit writes: > Only managed PCI resource in the driver is the iomapped bar. However the = bar > is unmapped in the same function. Therefore using the device-managed > versions just causes overhead, w/o any benefit. Once this is switched to = the > non-managed versions, there's nothing left to be managed for > pcim_enable_device(). Therefore we can reduce overhead here too and switc= h to > the non-managed version as well. This includes removing the no longer nee= ded > call to pcim_pin_device(). > > Signed-off-by: Heiner Kallweit Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen