linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 2/2] arm64: dts: armada-3720: align LED node name with bindings
Date: Fri, 05 Jul 2024 14:49:41 +0200	[thread overview]
Message-ID: <875xtkj95m.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20240701150340.560243-2-krzysztof.kozlowski@linaro.org>

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> Bindings expect the LED node names to follow certain pattern, see
> dtbs_check warnings:
>
>   armada-3720-gl-mv1000.dtb: leds: 'power', 'vpn', 'wan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied on mvebu/dt64

Thanks,

Gregory
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> index 07c14bf04b83..56930f2ce481 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> @@ -57,17 +57,17 @@ switch {
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		vpn {
> +		led-vpn {
>  			label = "green:vpn";
>  			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
>  		};
>  
> -		wan {
> +		led-wan {
>  			label = "green:wan";
>  			gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
>  		};
>  
> -		led_power: power {
> +		led_power: led-power {
>  			label = "green:power";
>  			gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
>  			default-state = "on";
> -- 
> 2.43.0


  reply	other threads:[~2024-07-05 12:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 15:03 [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys node name with bindings Krzysztof Kozlowski
2024-07-01 15:03 ` [PATCH 2/2] arm64: dts: armada-3720: align LED " Krzysztof Kozlowski
2024-07-05 12:49   ` Gregory CLEMENT [this message]
2024-07-05 12:49 ` [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys " Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xtkj95m.fsf@BLaptop.bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).