* [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys node name with bindings
@ 2024-07-01 15:03 Krzysztof Kozlowski
2024-07-01 15:03 ` [PATCH 2/2] arm64: dts: armada-3720: align LED " Krzysztof Kozlowski
2024-07-05 12:49 ` [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys " Gregory CLEMENT
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-01 15:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect the GPIO key node names to follow certain pattern, see
dtbs_check warnings:
armada-3720-gl-mv1000.dtb: keys: 'reset' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)...
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
index 63fbc8352161..07c14bf04b83 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
@@ -41,7 +41,7 @@ vcc_sd_reg1: regulator {
keys {
compatible = "gpio-keys";
- reset {
+ button-reset {
label = "reset";
linux,code = <KEY_RESTART>;
gpios = <&gpionb 14 GPIO_ACTIVE_LOW>;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: armada-3720: align LED node name with bindings
2024-07-01 15:03 [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys node name with bindings Krzysztof Kozlowski
@ 2024-07-01 15:03 ` Krzysztof Kozlowski
2024-07-05 12:49 ` Gregory CLEMENT
2024-07-05 12:49 ` [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys " Gregory CLEMENT
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-01 15:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect the LED node names to follow certain pattern, see
dtbs_check warnings:
armada-3720-gl-mv1000.dtb: leds: 'power', 'vpn', 'wan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
index 07c14bf04b83..56930f2ce481 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
@@ -57,17 +57,17 @@ switch {
leds {
compatible = "gpio-leds";
- vpn {
+ led-vpn {
label = "green:vpn";
gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
};
- wan {
+ led-wan {
label = "green:wan";
gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
};
- led_power: power {
+ led_power: led-power {
label = "green:power";
gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
default-state = "on";
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys node name with bindings
2024-07-01 15:03 [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys node name with bindings Krzysztof Kozlowski
2024-07-01 15:03 ` [PATCH 2/2] arm64: dts: armada-3720: align LED " Krzysztof Kozlowski
@ 2024-07-05 12:49 ` Gregory CLEMENT
1 sibling, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2024-07-05 12:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrew Lunn, Sebastian Hesselbarth,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Bindings expect the GPIO key node names to follow certain pattern, see
> dtbs_check warnings:
>
> armada-3720-gl-mv1000.dtb: keys: 'reset' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)...
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> index 63fbc8352161..07c14bf04b83 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> @@ -41,7 +41,7 @@ vcc_sd_reg1: regulator {
> keys {
> compatible = "gpio-keys";
>
> - reset {
> + button-reset {
> label = "reset";
> linux,code = <KEY_RESTART>;
> gpios = <&gpionb 14 GPIO_ACTIVE_LOW>;
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: dts: armada-3720: align LED node name with bindings
2024-07-01 15:03 ` [PATCH 2/2] arm64: dts: armada-3720: align LED " Krzysztof Kozlowski
@ 2024-07-05 12:49 ` Gregory CLEMENT
0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2024-07-05 12:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrew Lunn, Sebastian Hesselbarth,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Bindings expect the LED node names to follow certain pattern, see
> dtbs_check warnings:
>
> armada-3720-gl-mv1000.dtb: leds: 'power', 'vpn', 'wan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> index 07c14bf04b83..56930f2ce481 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> @@ -57,17 +57,17 @@ switch {
> leds {
> compatible = "gpio-leds";
>
> - vpn {
> + led-vpn {
> label = "green:vpn";
> gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
> };
>
> - wan {
> + led-wan {
> label = "green:wan";
> gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
> };
>
> - led_power: power {
> + led_power: led-power {
> label = "green:power";
> gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
> default-state = "on";
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-05 12:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 15:03 [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys node name with bindings Krzysztof Kozlowski
2024-07-01 15:03 ` [PATCH 2/2] arm64: dts: armada-3720: align LED " Krzysztof Kozlowski
2024-07-05 12:49 ` Gregory CLEMENT
2024-07-05 12:49 ` [PATCH 1/2] arm64: dts: armada-3720: align GPIO keys " Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).