From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0A0AC48260 for ; Fri, 16 Feb 2024 20:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NE+JwCwxuXabiXO5ugkpARcN2FfMj4uqFKR50K5WiQU=; b=cWz8axOp+ONLhH oQNZ2VpyyTuspfNUb7FumF9fb+rdzBtAcVzNOIPXzJhTu8n6hyo3JJ+EPr6D+uuzLO7QpUHQAYXQq F26gS2UAm5wtEEdZLodzwJ0BEedkI9ewUC7l438K4NIx6lVnHWtR3w/P8RL4AdSLOS/wlDziIw3qx MnzzaEdCbUF93XKagITuaw641OQ40ALNdk4OZ7bwWGlZXlemxe1UNSddzZ2fM5Ix6HqN1XKHr7dM7 9fL2WmRM1Hb12YDe2Hy9Eq7wMF9/BVlbAAwuHMBI4LHc+jMpXTxvvk86HaJdq/fmc3V+q7atfIDky 2kAHpRTQl50hX7VI2EcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb5A6-00000003ir7-47i6; Fri, 16 Feb 2024 20:50:22 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb59x-00000003ipA-2AxQ; Fri, 16 Feb 2024 20:50:21 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708116611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/MiNcyV6cuA2bEaO9pcAB0n2lgB9jPzAIMw9Rcvipmc=; b=IHl9ORoCzIXPoV6LABWoXZZeMThG96CoIBAQQ027SKATZEF6fDtWiZ+bTW4kAY8lPa27DL Eo4oTrIMRPfMUn84ibsglx2TpDLUv3K0b85/SkLNV1z+KsIqNFC7n0oEiMVgIxu87uW7SM gvkoKgs9jvUqkGi9yLTP7IWTTMRVxzGIMhqUE2sUzhakn9LAeuR0LULqYWkqRFEWvIasLv EUrOGTu9obLyx99g44CXIknPz4XE1ItIo56xNMLgDlofUnnpx2GK7jbWIUKgbTBEzntOXN hNXXARggoTtPidzCj/D3DyFrgc7uETU2mjLp+kb+XMhpRhqnHgMsYlzQq7YGSg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708116611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/MiNcyV6cuA2bEaO9pcAB0n2lgB9jPzAIMw9Rcvipmc=; b=UQZ1bO66o3f1pXva2taPAXPSKlpKkqJV7Ezk94IO8xuYtdCOe4hdhfUQZY8wcsbasEmJJ8 cRHlhm4HLiyx/WCw== To: Anup Patel , Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley Cc: Marc Zyngier , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Anup Patel Subject: Re: [PATCH v12 22/25] irqchip: Add RISC-V advanced PLIC driver for direct-mode In-Reply-To: <20240127161753.114685-23-apatel@ventanamicro.com> References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-23-apatel@ventanamicro.com> Date: Fri, 16 Feb 2024 21:50:10 +0100 Message-ID: <875xyocewt.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_125013_860600_5014B7F9 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 27 2024 at 21:47, Anup Patel wrote: > +static int aplic_direct_irqdomain_translate(struct irq_domain *d, > + struct irq_fwspec *fwspec, > + unsigned long *hwirq, > + unsigned int *type) Please align the arguments to the first argument of the first line and use the 100 characters, i.e. static int aplic_direct_irqdomain_translate(struct irq_domain *d, struct irq_fwspec *fwspec, unsigned long *hwirq, unsigned int *type) { All over the place. > +{ > + struct aplic_priv *priv = d->host_data; > + > + return aplic_irqdomain_translate(fwspec, priv->gsi_base, > + hwirq, type); > +} > + > +static int aplic_direct_irqdomain_alloc(struct irq_domain *domain, > + unsigned int virq, unsigned int nr_irqs, > + void *arg) > +{ > + int i, ret; > + unsigned int type; > + irq_hw_number_t hwirq; > + struct irq_fwspec *fwspec = arg; > + struct aplic_priv *priv = domain->host_data; > + struct aplic_direct *direct = > + container_of(priv, struct aplic_direct, priv); Variable ordering. Please make this consistent according to documentation. > + ret = aplic_irqdomain_translate(fwspec, priv->gsi_base, > + &hwirq, &type); > + if (ret) > + return ret; > + > + for (i = 0; i < nr_irqs; i++) { > + irq_domain_set_info(domain, virq + i, hwirq + i, > + &aplic_direct_chip, priv, > + handle_fasteoi_irq, NULL, NULL); > + irq_set_affinity(virq + i, &direct->lmask); > + /* See the reason described in aplic_msi_irqdomain_alloc() */ I still have to understand that "reason". :) > + irq_set_status_flags(virq + i, IRQ_DISABLE_UNLAZY); > + } Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel