From: Marc Zyngier <maz@kernel.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Zenghui Yu <yuzenghui@huawei.com>,
Vincent Donnefort <vdonnefort@google.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] KVM: arm64: Properly return allocated EL2 VA from hyp_alloc_private_va_range()
Date: Mon, 28 Aug 2023 18:16:25 +0100 [thread overview]
Message-ID: <875y4zozo6.wl-maz@kernel.org> (raw)
In-Reply-To: <e311ac4b-48e6-ea8f-3157-6f78bc5b9ad9@linaro.org>
Hi Philippe,
On Mon, 28 Aug 2023 18:00:54 +0100,
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Hi Marc,
>
> On 28/8/23 17:31, Marc Zyngier wrote:
> > Marek reports that his RPi4 spits out a warning at boot time,
> > right at the point where the GICv2 virtual CPU interface gets
> > mapped.
> >
> > Upon investigation, it seems that we never return the allocated
> > VA and use whatever was on the stack at this point. Yes, this
> > is good stuff, and Marek was pretty lucky that he ended-up with
> > a VA that intersected with something that was already mapped.
> >
> > On my setup, this random value is plausible enough for the mapping
> > to take place. Who knows what happens...
> >
> > Cc: Vincent Donnefort <vdonnefort@google.com>
> > Fixes: f156a7d13fc3 ("KVM: arm64: Remove size-order align in the nVHE hyp private VA range")
>
> I don't see your kvmarm-6.6 merged by Paolo, is it too late to squash
> and send a new PR?
In general, I keep the commits that are in -next stable (no squashing,
no rebasing), and only the merge commits that drag these commits onto
-next are throw-away (this allows me to rebuild the whole branch
without changing any of the commit SHAs).
So no, I won't send a new PR right now. However, I'll stick the patch
in -next and will aim to send Paolo another PR later this week or
early next week.
> Anyhow:
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks!
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-28 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 15:31 [PATCH] KVM: arm64: Properly return allocated EL2 VA from hyp_alloc_private_va_range() Marc Zyngier
2023-08-28 17:00 ` Philippe Mathieu-Daudé
2023-08-28 17:16 ` Marc Zyngier [this message]
2023-08-28 22:16 ` Philippe Mathieu-Daudé
2023-08-29 8:03 ` Vincent Donnefort
2023-08-29 9:00 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y4zozo6.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=oliver.upton@linux.dev \
--cc=philmd@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=vdonnefort@google.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).