From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBB33EB64DA for ; Wed, 5 Jul 2023 08:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=llKA8yuth4eoPRVhS+XnRD6HVF7rktc7EgVvKYUrtws=; b=W2F5JoskItDDkw BD/89EUjCCObHfkiAc1YrvVlD6XKPAPQ6xk4bh4TvcYwcP6Y8pld2Y2EIa2Uk6RNmrk7fsrPgAvUD 9M+DzA/8d6B2zaRL8WDsbBXvMbxFNObdQf/QzNhq1vkgMsqp8rIRmddn10TVTCqZlJ8jhosPaIIoC Ky8ERFI8xv8Kt/E5WQeXyvoD0d1D9GgMsvTuIUczZv3kQBqmWYIF/r4IcKtHEju2LsYFZS4A8i8EP /ZyfU7TDwJf7UWAFm1eCLWwMkHzh50vNUFWXo7P7bCwNPy1x1WZqV+AVx4mxaKFGrr62o79lSmxSn prNWaohBdxr5lhmd+7Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGxn9-00FC9P-1n; Wed, 05 Jul 2023 08:23:15 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGxn6-00FC8E-1p for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 08:23:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688545388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TdhQb+Syo7axqoDqvE+d+9JDiCWJ3NaRZrNyouSZxA4=; b=BQ53SPYW6e9ueCxnezioiP3wCksnsweCDsB/IbYD6gDEAvYCyaK6WUFGYFI/7GMp3UBwsI F9Q/kKWlmZnxoEZTfaO++Z9FHhjNuNDRhal76ehQmLwSrzenP3LItNGF9+HGHO3hEJFlTh frnnsv2xpsN8XDwpP9h5HDSsa0iB71k= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-l_9OG4cRPD2WJsLQFPfsUA-1; Wed, 05 Jul 2023 04:23:07 -0400 X-MC-Unique: l_9OG4cRPD2WJsLQFPfsUA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2b6e73c6da6so31325751fa.0 for ; Wed, 05 Jul 2023 01:23:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688545385; x=1691137385; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TdhQb+Syo7axqoDqvE+d+9JDiCWJ3NaRZrNyouSZxA4=; b=arLV17wE/hSY6vtxmDS8mn3QqX/AbblmsvXm3Ji5L9TO5mUrTbYX5bnFtHKCq29exW gNP8gcyzfO3ZXt4TKs/XMKgkKrhouxBR0cSUNmKqIgm+IdCQ1x5k2OA1plO7VrDPOZzl FsXh/6EreSlEbFP9fD7XGS+fBRolJTy5CFMkUkmF/Ldfz9ZvAVX2LxIGdS/XcwFC4/OC le+7bFSWo80sjbqAsUDQah1qf8p/vcaeHhiz0abONq9XIvZuYwuBUephOR2q32jorlwb Phv5+6L7MxWAUX7FLS6qrHy8MXmE/T0Ncz9BI29pMRzwYStc3RLmhMplmEC2WE3YkZ8c 2gJg== X-Gm-Message-State: ABy/qLb/mjnRzhOVmYfIRjFd919bfpsvbn5KOjWeunTCAKSWIpkrVkBQ BpksqD6bkum8540BJX1FnDaQlD0gI0+UIOe46knT5brNkq8PX+7vrXfa4DDcaMToZ359LjkNLgb rIqpOjIAr9mxm9VJmqa7wBdXqW9zPwCMIyt8= X-Received: by 2002:a2e:8095:0:b0:2b6:a344:29cf with SMTP id i21-20020a2e8095000000b002b6a34429cfmr10093146ljg.17.1688545385617; Wed, 05 Jul 2023 01:23:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlGDvUCFfme/Nn/ZdctOdvEvefSFNX7STUaOhlHec73G4bbSvs9bTxRZM7iY07V1SqMwOI36OA== X-Received: by 2002:a2e:8095:0:b0:2b6:a344:29cf with SMTP id i21-20020a2e8095000000b002b6a34429cfmr10093130ljg.17.1688545385203; Wed, 05 Jul 2023 01:23:05 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id r13-20020a05600c458d00b003fa9a00d74csm1422474wmo.3.2023.07.05.01.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 01:23:04 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Subject: Re: [PATCH 01/10] fbdev: Add fb_ops init macros for framebuffers in DMA-able memory In-Reply-To: <20230704160133.20261-2-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-2-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 10:23:03 +0200 Message-ID: <875y6ysr6g.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_012312_686406_286D739E X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: Hello Thomas, > Add initializer macros for struct fb_ops for framebuffers in DMA-able > memory areas. Also add a corresponding Kconfig token. As of now, this > is equivalent to system framebuffers and mostly useful for labeling > drivers correctly. > > A later patch may add a generic DMA-specific mmap operation. Linux > offers a number of dma_mmap_*() helpers for different use cases. > > Signed-off-by: Thomas Zimmermann > Cc: Helge Deller > --- > drivers/video/fbdev/Kconfig | 8 ++++++++ > include/linux/fb.h | 13 +++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index cecf15418632..f14229757311 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -168,6 +168,14 @@ config FB_DEFERRED_IO > bool > depends on FB > > +config FB_DMA_HELPERS > + bool > + depends on FB > + select FB_SYS_COPYAREA > + select FB_SYS_FILLRECT > + select FB_SYS_FOPS > + select FB_SYS_IMAGEBLIT > + > config FB_IO_HELPERS > bool > depends on FB > diff --git a/include/linux/fb.h b/include/linux/fb.h > index 1d5c13f34b09..1191a78c5289 100644 > --- a/include/linux/fb.h > +++ b/include/linux/fb.h > @@ -594,6 +594,19 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf, > __FB_DEFAULT_SYS_OPS_DRAW, \ > __FB_DEFAULT_SYS_OPS_MMAP > > +/* > + * Helpers for framebuffers in DMA-able memory > + */ > + The comment for I/O memory helpers says: /* * Initializes struct fb_ops for framebuffers in I/O memory. */ I think that would be good to have consistency between these two, so something like: /* * Initializes struct fb_ops for framebuffers in DMA-able memory. */ > +#define __FB_DEFAULT_DMA_OPS_RDWR \ > + .fb_read = fb_sys_read, \ > + .fb_write = fb_sys_write > + > +#define __FB_DEFAULT_DMA_OPS_DRAW \ > + .fb_fillrect = sys_fillrect, \ > + .fb_copyarea = sys_copyarea, \ > + .fb_imageblit = sys_imageblit > + Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel