From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 117DAC7EE29 for ; Tue, 13 Jun 2023 08:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:Cc:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hA+iphn/Map5OLJmWWMWBX6Gy48oP/m0Z96/iabAFXQ=; b=rgt22LDDnJ2UcUt+BvENqZLUea kfAv8EAD+0cGNFJJfctblxr5gp+FD3CO1X6nPOpPSy2erwPpTd/DcaYKGnT7vxhjR6pVGgczJVUz2 CQhOgEvste0PD66AD0nhK2Pinlp8aIs64d2eLuisOcDS+aB/9SjhXnNuCm1qksQEHDeNrTarV+uDv NAfYJ3YzhysIYmHEXdF7Zr/7929aUT2zuDzLYd/KuuL+4p3M1HYUZiu5AhugZD090dYm8RRQJ3ngm CdZYuEsFWEdaQAW/PxbryUf2EGFCQ2JTtPJi2o8nysI/wrvH0Xi0yKZBlawYgEx/lXnhBh2xi52aF LUHiP0OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8za6-007PMC-1I; Tue, 13 Jun 2023 08:40:50 +0000 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8za3-007PLM-0w for linux-arm-kernel@lists.infradead.org; Tue, 13 Jun 2023 08:40:48 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4QgMT62WB0z9smX; Tue, 13 Jun 2023 10:40:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1686645642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F4YR6IC11dblIqgF9IfE7gEo2pRgRczWDAIr1+EuyLQ=; b=uHu3KnFjumsj3KVvsIxFa5qbz7R5TJoEBx6uzPIP9sPj+t/s4QhN2PBRzU9hQ3Z1ukHlk6 K5E3nwo9JPvEUni832RmtTxLZ4ajKne4JDpllxjTjtJtpa3/70x5VrUlzIAxCmRs0FITXB IAQsd9Cydes9Jys/2+edOYNSq/kVAoMn5Rpe1XGI5TyYZdrT/YZuPSMFJOQhrkTaemDZFL /6hF8VNRzVG0rBZEvJ+vZWyIpNeKyHJvp/Tg+fcjpz0ooTk3XLXtV/+1TirGKKDyU5qEAd ZcWbBi7Fs+uVLpC6+hZ2gZCYP2BTX7d9483Apo2SgMjGX+H7Ii+cRDM3ZzKLfQ== References: <20230529133433.56215-1-frank@oltmanns.dev> <69a0b07442116b52e359534d93433f55.sboyd@kernel.org> From: Frank Oltmanns To: Stephen Boyd Cc: Michael Turquette , Abel Vesa , Peng Fan , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Jacky Bai , Anson Huang , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: fractional-divider: Improve approximation when zero based In-reply-to: <69a0b07442116b52e359534d93433f55.sboyd@kernel.org> Date: Tue, 13 Jun 2023 10:40:33 +0200 Message-ID: <875y7r21ry.fsf@oltmanns.dev> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4QgMT62WB0z9smX X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_014047_471632_9E9C99FC X-CRM114-Status: GOOD ( 11.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, On 2023-06-12 at 14:39:00 -0700, Stephen Boyd wrote: > Quoting Frank Oltmanns (2023-05-29 06:34:33) >> Consider the CLK_FRAC_DIVIDER_ZERO_BASED flag when finding the best >> approximation for m and n. By doing so, increase the range of valid >> values for the numerator and denominator by 1. >> >> Cc: A.s. Dong > Signed-off-by: Frank Oltmanns >> --- >> I stumpled upon this, when familiarizing myself with clk drivers. Unfortunately, >> I have no boards to test this patch. It seems the only user of this flag in >> mainline is drivers/clk/imx/clk-composite-7ulp.c, therefore I'm cc-ing >> get_maintainers.pl --git-blame -f drivers/clk/imx/clk-composite-7ulp.c >> in the hopes of a wider audience. >> >> Thank you for considering this contribution, > > Thanks for looking at this. Can you add a kunit test (or a suite of > tests) to confirm that this doesn't break existing functionality and > also improves a case that would have failed or been suboptimal before? Thank you for your feedback, I've submitted a V2 that contains the tests: https://lore.kernel.org/lkml/20230613083626.227476-1-frank@oltmanns.dev/ Thanks, Frank _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel