From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 332D3C43334 for ; Wed, 1 Jun 2022 16:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=799ZPR1V3Rgm/kSjW7mkIKcCwvyvA0QxI1e6TEIIVP4=; b=ChbABT7gp9vW0G TYeBS3Xc6HpwAMiCmONxz97cOvKxO8MJKvDt9q9uF0SkpWv3mr72Gy7rzqgWaQS9JktbDVEsCaTvZ AtRiPLNOTP4bXrWTnRXt6yHmyncQZDZC7tS3x6ZyegF/b5gvNGVlJzZH6okyLknKB545E5SaA7XM5 uxAELRrwt96oVqiWFaYKCeZU5h4r695nBvVNYzZDxw4WwhN0OUwwbNZ4wBigwe+kjs5QfNGKkpzvZ TttH08Xi1ZTN20oI8lu0kOoq5LwI/xyJT30tmGeIYlYfoWW1FOIFk1pr9ugR9FPj5IP+wyYWTnKco Ao03sis73p7c7KTq6lnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwRTB-00HBNW-Ln; Wed, 01 Jun 2022 16:45:17 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwRT8-00HBN3-QU for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 16:45:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C1C8615C8; Wed, 1 Jun 2022 16:45:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78EB2C385B8; Wed, 1 Jun 2022 16:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654101913; bh=Tk8FjEHF1VQW21T/3UF5gV/iXWDoIO9vTAu9SOy0ugA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K+FGoPNJRMr4EldsD6jixjcNPuQ/jeQqke066Hxk/77kIyy2IVZTp+t+1N5R+gaLZ oDw68sktsv7IGzfCZr15yqx7F/7MDC1L04DqFbTDqNuiBv4jyM4vuu4wPdHOe2ljFe pbpzoiaLIYZGTzVFeVSYo63OtmCMxWcFNcZVmsZaOFMDz6LtBU/S+/xgPSTcWRBJ0D 5aQQweihftbPu8/W2sBrPnAfVXpt5AIRBqtUeWMP7dMayhrDteEp4Ubetic091PiLh /ZzeG2gOU+x21elQ6kKKARKrP4Wlu7y5hQdf8yyfHqZ9FfaEUV65W5eZ8ph/evsms3 dDCVdbdxND9Rg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nwRT5-00F29s-2q; Wed, 01 Jun 2022 17:45:11 +0100 Date: Wed, 01 Jun 2022 17:45:10 +0100 Message-ID: <875ylk5o4p.wl-maz@kernel.org> From: Marc Zyngier To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ricardo Koller , Oliver Upton , catalin.marinas@arm.com, will@kernel.org, eric.auger@redhat.com, yuzhe@nfschina.com, justin.he@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH AUTOSEL 5.18 35/49] KVM: arm64: vgic: Do not ignore vgic_its_restore_cte failures In-Reply-To: <20220601135214.2002647-35-sashal@kernel.org> References: <20220601135214.2002647-1-sashal@kernel.org> <20220601135214.2002647-35-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, ricarkol@google.com, oupton@google.com, catalin.marinas@arm.com, will@kernel.org, eric.auger@redhat.com, yuzhe@nfschina.com, justin.he@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_094514_937543_5D17D47C X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 01 Jun 2022 14:51:59 +0100, Sasha Levin wrote: > > From: Ricardo Koller > > [ Upstream commit a1ccfd6f6e06eceb632cc29c4f15a32860f05a7e ] > > Restoring a corrupted collection entry (like an out of range ID) is > being ignored and treated as success. More specifically, a > vgic_its_restore_cte failure is treated as success by > vgic_its_restore_collection_table. vgic_its_restore_cte uses positive > and negative numbers to return error, and +1 to return success. The > caller then uses "ret > 0" to check for success. > > Fix this by having vgic_its_restore_cte only return negative numbers on > error. Do this by changing alloc_collection return codes to only return > negative numbers on error. > > Signed-off-by: Ricardo Koller > Reviewed-by: Oliver Upton > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/20220510001633.552496-4-ricarkol@google.com > Signed-off-by: Sasha Levin Same thing here. This wasn't tagged for stable. I don't think there is much value in taking this in isolation. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel