From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 606D6C433F5 for ; Sat, 23 Apr 2022 09:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=813884YIp0S+59RpNbyilDSoZesWz4y3bcj263Tscb4=; b=tXm7FGLAsnF8tj nIbsosfLZdvfwo1d3JSVuR36d/2Amt8U8xGn9hF2i2l72oyWTTAB6Qt/sna2bRim89YBohXvbZm2Y hWuDiADY2+LPYiJHgMWaLYGTki3EVpvo35vzqWrwieptp/wK2Sj5s1xgwwTMJNEJVty/EYvfrD6mI 6ZXNyJ35D2MTxok9eJmg/Px4eeYWZQS5IszJjgzraFGiycqjZaAZSz7KfU/zdvSQT4hdd9vZd5hXf DeLz7O8cC4NuiDyyN9qzo9cURQYD8A1eTbFHSo3JwrwOnIGTVx+YkkkLM0fcHyPHzFVWDqB5vzv6A UDjp7GIbVRk1Gsm+SYpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niCIy-003wz7-VS; Sat, 23 Apr 2022 09:43:53 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niCIv-003wxU-Fn for linux-arm-kernel@lists.infradead.org; Sat, 23 Apr 2022 09:43:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E002760EAE; Sat, 23 Apr 2022 09:43:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C6CAC385A0; Sat, 23 Apr 2022 09:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650707027; bh=Lz9EJnShpChhsUOfGlRiZWzsOfwSCzPxuLGssgfvEwc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nlv2ET/6t4D6e3sVZiFDXqnSujW84YVlYR+qrIegsH+rUcH9C86ie1g16158e5Zu7 kZEFQpKbAbGhId8Q9l5ElUEezMTFvXPiTaNbZcSXGXpdfRnR/+zd6bx6kOJVFiTeCy T5//EgW6rCw9UX4sPpbrPGStnkGKMKEnczust9dvWQKqW1cx+ceFMJd9ROTOgEPRfR dwAEjqLz/OH9oO22UK5SZOwWGaKBz3kDHAh5B7DImXEfosZsGuuPE0tfUwfjqIXsTY ayb+GanpOU+cVHalFzI+Fk66g7C+kHswewiwLxIS6E2x6Kw0DU3X4VYBwo6xMY4pUB 6NFEUm7D3C1ug== Received: from sofa.misterjones.org ([185.219.108.64] helo=billy-the-mountain.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1niCIq-006MPU-Q7; Sat, 23 Apr 2022 10:43:44 +0100 Date: Sat, 23 Apr 2022 10:43:44 +0100 Message-ID: <875yn0cey7.wl-maz@kernel.org> From: Marc Zyngier To: Krzysztof Kozlowski Cc: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Thomas Gleixner , Andrew Jeffery , Eddie James , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH 1/2] irqchip/aspeed-i2c-ic: Fix irq_of_parse_and_map() return value In-Reply-To: <3eb57a4c-95b6-0bf5-aa1a-90ee2fd336e1@linaro.org> References: <20220422104536.61451-1-krzysztof.kozlowski@linaro.org> <3eb57a4c-95b6-0bf5-aa1a-90ee2fd336e1@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: krzysztof.kozlowski@linaro.org, brendanhiggins@google.com, benh@kernel.crashing.org, joel@jms.id.au, tglx@linutronix.de, andrew@aj.id.au, eajames@linux.ibm.com, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220423_024349_629627_937971E1 X-CRM114-Status: GOOD ( 22.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 23 Apr 2022 10:30:53 +0100, Krzysztof Kozlowski wrote: > > On 22/04/2022 12:45, Krzysztof Kozlowski wrote: > > The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. > > > > Fixes: f48e699ddf70 ("irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed") > > Signed-off-by: Krzysztof Kozlowski > > --- > > drivers/irqchip/irq-aspeed-i2c-ic.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/irq-aspeed-i2c-ic.c b/drivers/irqchip/irq-aspeed-i2c-ic.c > > index a47db16ff960..cef1291ae783 100644 > > --- a/drivers/irqchip/irq-aspeed-i2c-ic.c > > +++ b/drivers/irqchip/irq-aspeed-i2c-ic.c > > @@ -77,7 +77,7 @@ static int __init aspeed_i2c_ic_of_init(struct device_node *node, > > } > > > > i2c_ic->parent_irq = irq_of_parse_and_map(node, 0); > > - if (i2c_ic->parent_irq < 0) { > > + if (!i2c_ic->parent_irq) { > > ret = i2c_ic->parent_irq; > > This is wrong (same in patch 2). I will send a v2. While you're at it, please add a cover letter when sending a series containing more than a single patch. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel