From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1E58C433F5 for ; Wed, 9 Mar 2022 07:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lfuNDInG0JOeaZLPY2Fn9m+ck8OmGjBdttu7H2cYAvk=; b=aKjmMWLx0mIQcz 3jEiAbKBPkHwW6QHGdnIFlzY/kTF6PPemvTCfq7Jxo8ow/EPMgl3pAO8PCQeC2yMUNsits+GY5xUx oAINoFZZ7KkBfy5d73RkmY7bzlQYZuU7xSxi7m92HErsP5xnqYlP+QE3wwa9c7MRKrefv1SAQvf8P dP4nSJ43zPz3dYdq76Ju4E6bU+aEa8NuK5Z2tnqJlNJ5qMW52L6uDyXJ9MaMthxLLp0rGiM51uvCF Nn6mJyW/RLTtqZ48FiHZpaDyhVq3sibwZ4PWbBGDZhcOnv+HvWQwR0nnGJLY07NFomUL+/AAwnILs s8/OZ1Pyw4cVyJTQdSZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRqQ0-007ZQC-QC; Wed, 09 Mar 2022 07:07:32 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRqPx-007ZPF-40 for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 07:07:31 +0000 Received: by mail-wr1-x430.google.com with SMTP id q14so1525645wrc.4 for ; Tue, 08 Mar 2022 23:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=UKkOGj96yEPkJXREWpXf/ZxC/thW+x6mQGM5X+KzoqI=; b=Vm5nzBF+VMiWvwLDRlVhoTttIZnnwG9hQkgmU6lhcEKjellU9RaCXIbHUQ+s9vopbh fqUxjfZu9KfNHw0ik21qV5WvsEPBLb2xLeCE8bYKqM/3o3HZ1rPywXSqZ9IE+PZaAjp+ AawEkLPcP0HZjlHvEiAcW9G3xfjwubjC6WHmMqI4DP4R5u2skH7xfL1CbfI0Jypn/WjX 7XB4E+IxevaAP46ENlzhPOzW1MAcpzDA95PH3tYZ5W/2xTrtnpB5X7JR9OtP2Y/NCE2t 0iHGLJSrJsFeBMJgqCzv2c+BS8uvMLvBEeShcEIIf/XXswwqrpXuzW0N/y6TKZWWP7jw p/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=UKkOGj96yEPkJXREWpXf/ZxC/thW+x6mQGM5X+KzoqI=; b=qWg9VyhHxpMiSnACf+8dbWul6OJuUKaEOjbcQ4+QVutaMMhPWoHwOR4KzQ6mWHmrz5 /PZe84Vmlt2TLe27RL/QHDu+2iUPnz00DDne1f5a27f4MSoxtxvlHLwi08UhLSHX8u3J VUeamyLVuV5aYqiIIPd16Ej+kDBg6PH7lX+vZjPmG7k+HRbjSYLmVCaASpyyP49Xpu52 O7idAldGrP6wvxMgJuIesqPTi0q+eol8EG5DqPr7Vg0Bh4x+XslS+txx+RLOmYfQ1asj BNSVtA9Has1bncIwUJ2Eno0eMsYvc4qtLdNtTPq7QkUJzYlXlvM8iK+xxebjmJAB6HhE +hjg== X-Gm-Message-State: AOAM532zxEurkixFD56MDz5f3ETgVoKUyBg6Ah74y5/hypGZA5qOw3Db fSkk+RgsufliYaVX0Q2YdKToCg== X-Google-Smtp-Source: ABdhPJzlhZkmPvte5X0WJu7dgTlK9ftWSz9F9e479R/RNfghnaKH7QPJhwJ/dXiKt3gcN/HGMjhong== X-Received: by 2002:a5d:47a4:0:b0:1f0:46e4:19bc with SMTP id 4-20020a5d47a4000000b001f046e419bcmr16034223wrb.601.1646809646825; Tue, 08 Mar 2022 23:07:26 -0800 (PST) Received: from localhost ([2a01:e0a:a84:e4a0:bc38:63f8:c31:e108]) by smtp.gmail.com with ESMTPSA id k18-20020adfe8d2000000b0020294da2b42sm1240410wrn.117.2022.03.08.23.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 23:07:26 -0800 (PST) From: Mattijs Korpershoek To: cgel.zte@gmail.com, dmitry.torokhov@gmail.com Cc: matthias.bgg@gmail.com, lv.ruyi@zte.com.cn, fengping.yu@mediatek.com, m.felsch@pengutronix.de, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Zeal Robot Subject: Re: [PATCH] input: fix variable type In-Reply-To: <20220308025054.2077162-1-lv.ruyi@zte.com.cn> References: <20220308025054.2077162-1-lv.ruyi@zte.com.cn> Date: Wed, 09 Mar 2022 08:07:25 +0100 Message-ID: <875yontxhu.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_230729_264431_45DDE737 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 02:50, cgel.zte@gmail.com wrote: > From: Lv Ruyi (CGEL ZTE) > > The irq is defined unsigned int. If the platform_get_irq return a negative > value, data type cast may result in error. > > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi (CGEL ZTE) > --- > drivers/input/keyboard/mt6779-keypad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c > index 5ff23250ed37..0dbbddc7f298 100644 > --- a/drivers/input/keyboard/mt6779-keypad.c > +++ b/drivers/input/keyboard/mt6779-keypad.c > @@ -91,7 +91,7 @@ static void mt6779_keypad_clk_disable(void *data) > static int mt6779_keypad_pdrv_probe(struct platform_device *pdev) > { > struct mt6779_keypad *keypad; > - unsigned int irq; > + int irq; > u32 debounce; > bool wakeup; > int error; Reviewed-by: Mattijs Korpershoek > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel