From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49FD2C433F5 for ; Thu, 2 Sep 2021 18:13:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 142C0610A2 for ; Thu, 2 Sep 2021 18:13:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 142C0610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lW1VvFUn5c73RE5WQ7WsIL3IqWsp5lECN/0i3nQaeg4=; b=ss8o15WMo62hBb z7UrA5QkmSbzdZ/ZjtycI61K+k2dVW1I1xOvBCqScCk02ziRvBTOYechFqZHW1bYwPgVI/u6Wb985 YsEkZyMsLv9HnmBK8AX2QvLZrcj3nCyf1xsqHfp8oyv+5/t88rJdd40UO8YC3IqBFU44BIDonuq67 hFtzOQM3zI5BE+1B1lOLijkjwlZKFqcB1UL6e83S9fiQ8xmAIRjPARHCSnlVo/fvde0Df2+cogL0M ObuhAk3DGQ+4f5umr3c0lgrYUXzlZT+64OZMRTURQ6Ee1Jz6uv1y4/s1PRBxBtp8eboPgntmP4OqJ KtjuX4NqQZkk0NdDm2UQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLrBq-00AH4y-Fr; Thu, 02 Sep 2021 18:11:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLrBn-00AH4Y-J7 for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 18:11:52 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 235E360724; Thu, 2 Sep 2021 18:11:51 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mLrBl-008h0e-4X; Thu, 02 Sep 2021 19:11:49 +0100 Date: Thu, 02 Sep 2021 19:11:48 +0100 Message-ID: <875yvix2xn.wl-maz@kernel.org> From: Marc Zyngier To: Jia He Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Liu Shixin , Eric Auger , Kees Cook , Nick Desaulniers , Shenming Lu , Sami Tolvanen , Lorenzo Pieralisi , Xiaoming Ni , Zenghui Yu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] KVM: arm64: Add memcg accounting to KVM allocations In-Reply-To: <20210902002801.32618-2-justin.he@arm.com> References: <20210902002801.32618-1-justin.he@arm.com> <20210902002801.32618-2-justin.he@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: justin.he@arm.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, liushixin2@huawei.com, eric.auger@redhat.com, keescook@chromium.org, ndesaulniers@google.com, lushenming@huawei.com, samitolvanen@google.com, lorenzo.pieralisi@arm.com, nixiaoming@huawei.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_111151_684381_E4038738 X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 02 Sep 2021 01:28:01 +0100, Jia He wrote: > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > allocations"), it would be better to make arm64 KVM consistent with > common kvm codes. > > The memory allocations of VM scope should be charged into VM process > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > There remained a few cases since these allocations are global, not in VM > scope. > > Signed-off-by: Jia He > --- > arch/arm64/kvm/arm.c | 6 ++++-- > arch/arm64/kvm/mmu.c | 2 +- > arch/arm64/kvm/pmu-emul.c | 2 +- > arch/arm64/kvm/reset.c | 2 +- > 4 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..9d6f5bcaddef 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -289,10 +289,12 @@ long kvm_arch_dev_ioctl(struct file *filp, > > struct kvm *kvm_arch_alloc_vm(void) > { > + unsigned long sz = sizeof(struct kvm); If you are going to introduce an extra variable, please use the correct type (size_t). > + > if (!has_vhe()) > - return kzalloc(sizeof(struct kvm), GFP_KERNEL); > + return kzalloc(sz, GFP_KERNEL | GFP_KERNEL_ACCOUNT); Why both GFP_KERNEL and GFP_KERNEL_ACCOUNT? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel