From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFAEAC4338F for ; Thu, 12 Aug 2021 13:38:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AC28604AC for ; Thu, 12 Aug 2021 13:38:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AC28604AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jZeMgVfqYK3MuG/5DFxBmXecxEZ7V5eGEdzaSdF1Jjc=; b=W2UE7m3YJ4ORHA /TxVZwEL8MNnE0SgTwrA5OnaTJ7debWJd/opq589JRQCxG9floXRFBQ3RulTJZIl/I5npVQ4PIJNd bSF5CQaKIMxiVh3t2zehTvRrnenJotdThT+Pcq9UPumIjvhHj8zWrzDOIfOKn9kKHxtQXYJKAjuY5 KMJ3lhUEdFKQctHb7cPTXoaCVRbe+kpNGyDVsQd7BNnsluefksSnabhcjPg6IyGkYYo+inUwyONlY hUsojqc8dRNyZjr4hnahC2iGQZ39TVWzSBPF3IfnVGOXMjIeauZs9TBtGDAirVcHjQp3wIRNxCBHq a6lkOPzmzMQJqAbWhJcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEAt3-00AG9l-S7; Thu, 12 Aug 2021 13:36:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEAt0-00AG9B-CB for linux-arm-kernel@lists.infradead.org; Thu, 12 Aug 2021 13:36:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 156EF1042; Thu, 12 Aug 2021 06:36:39 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 300E93F70D; Thu, 12 Aug 2021 06:36:38 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [PATCH v3 05/13] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq() In-Reply-To: <87bl639l8n.wl-maz@kernel.org> References: <20210629125010.458872-1-valentin.schneider@arm.com> <20210629125010.458872-6-valentin.schneider@arm.com> <87bl639l8n.wl-maz@kernel.org> Date: Thu, 12 Aug 2021 14:36:35 +0100 Message-ID: <875ywa944c.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_063642_507198_5DF9B76F X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/08/21 08:26, Marc Zyngier wrote: > On Tue, 29 Jun 2021 13:50:02 +0100, > Valentin Schneider wrote: >> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c >> index ef30b4762947..e6d6d32ddcbc 100644 >> --- a/kernel/irq/manage.c >> +++ b/kernel/irq/manage.c >> @@ -1107,7 +1107,7 @@ static void irq_finalize_oneshot(struct irq_desc *desc, >> desc->threads_oneshot &= ~action->thread_mask; >> >> if (!desc->threads_oneshot && !irqd_irq_disabled(&desc->irq_data) && >> - irqd_irq_masked(&desc->irq_data)) >> + (irqd_irq_masked(&desc->irq_data) | irqd_irq_flow_masked(&desc->irq_data))) >> unmask_threaded_irq(desc); > > The bitwise OR looks pretty odd. It is probably fine given that both > side of the expression are bool, but still. I can fix this locally. > Thomas suggested that back in v1: https://lore.kernel.org/lkml/87v98v4lan.ffs@nanos.tec.linutronix.de/ I did look at the (arm64) disassembly diff back then and was convinced by what I saw, though I'd have to go do that again as I can't remember much else. > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel