From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC211C433B4 for ; Fri, 9 Apr 2021 10:36:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68E6561007 for ; Fri, 9 Apr 2021 10:36:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68E6561007 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C9ZcHxSlGkYcR8Gdt6bN5QlRDT7BJmtYcPT18jxaH1w=; b=DFBDV4ThR09dgwAubkb4q/MdS MypPYXoHDGhlF9bop0N1cLg5HzVlJV89D3VHm2FN8nCvqVkyKalnS4kz8gScjyOpccdR+miS80A/j QI1dreI+pzVVRope4WB60W2cIgVq1ixZaR5uHLO6bHhY614R6jKyM/o3dqIqvBcfWMGychlHvBEc5 TBhbnXFKj0NmSs6KciArC1KOPRs0ll746iYLWDDfhMt1iCg17PFdJjhT8nxZFxYKM8Cc9qDz7L/zn 6DzYmC5WQd6lgYArH1/KvU/6F0GSp+mnYmhuz/hP2h7IFN48LgvpFDbtbY8gQrr7jwCCwl8DoTsGd Le95D5oRA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUoT3-000QnF-PW; Fri, 09 Apr 2021 10:34:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUoT0-000QlB-IU for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 10:34:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X3JSYc09ZzGOmdOLVaF10Yg/XOfKeUdNffOsyCEmRqE=; b=J6+9NcEMbgI8DLwbVZ757cq0hV YiidU6lamAxMruSUNw1/+JtV1QhJ7j6e80YoR3CN6Vd700WYZ9NWCebBsAbpHcEbtiFX5bmVB4617 vln/t/80LirkOwIMu1pgUrybo1fS7W6Yw8dihcMcSN3q7gLiwOW4tWtSUgPYkJFBzSNSAhsvLgGgv ovZ2zOmQh+1kbo47eNpDB3l3D7ZqNRgdUpqCyKQWGgtxLFPgaNZJL94HAAJpLiT05nCmKAIGKlN8y 9dZqOQ1wX/Ed7J5gQIprAYMTXjN+jggSvIeUyvxnGRylpLcj18hCES5ZIQ79FL0nS0Lm6KtplI13l rYSjr0PA==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUoSx-004IDb-PQ for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 10:34:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B1AD1FB; Fri, 9 Apr 2021 03:34:15 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74EAF3F73D; Fri, 9 Apr 2021 03:34:14 -0700 (PDT) From: Valentin Schneider To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH 01/10] genirq: Add chip flag to denote automatic IRQ (un)masking In-Reply-To: <20210409101725.00007271@Huawei.com> References: <20210408154326.3988781-1-valentin.schneider@arm.com> <20210408154326.3988781-2-valentin.schneider@arm.com> <20210409101725.00007271@Huawei.com> Date: Fri, 09 Apr 2021 11:34:07 +0100 Message-ID: <875z0voig0.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_033419_896911_8B3C17E4 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, Thanks for taking a peek :) On 09/04/21 10:17, Jonathan Cameron wrote: > On Thu, 8 Apr 2021 16:43:17 +0100 > Valentin Schneider wrote: >> diff --git a/include/linux/irq.h b/include/linux/irq.h >> index bee82809107c..580b1b6b1799 100644 >> --- a/include/linux/irq.h >> +++ b/include/linux/irq.h >> @@ -219,6 +219,8 @@ struct irq_data { >> * irq_chip::irq_set_affinity() when deactivated. >> * IRQD_IRQ_ENABLED_ON_SUSPEND - Interrupt is enabled on suspend by irq pm if >> * irqchip have flag IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND set. >> + * IRQD_IRQ_FLOW_MASKED - Interrupt is masked by ACK. Only EOI can >> + * clear this. > > Nitpick of the day : Seems text above is using tabs for white space blocks > whereas you have used spaces. Make it consistent. > It's not consistent in the file so I guess you could clean that up, or > just go with making it consistent in this block. > I usually let my editor take the wheel when it comes to whitespace vs tabs, but it does look like it's not aligned with the rest here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel