* [PATCH] arm/dts: Add DT block for Netgear ReadyNAS NV+ v2 LCD panel
@ 2020-04-25 2:24 Brian J. Tarricone
2020-04-25 14:27 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Brian J. Tarricone @ 2020-04-25 2:24 UTC (permalink / raw)
To: linux-arm-kernel
Cc: andrew, gregory.clement, Brian J. Tarricone, jason,
sebastian.hesselbarth
The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
similar to the Netgear RN104, just with different GPIO assignments.
Signed-off-by: Brian J. Tarricone <brian@tarricone.org>
---
.../boot/dts/kirkwood-netgear_readynas_nv+_v2.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
index 8cc8550242ef..b13aee570804 100644
--- a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
+++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
@@ -113,6 +113,20 @@ sata@80000 { /* Connected to Marvell 88SM4140 SATA port multiplier */
};
};
+ auxdisplay {
+ compatible = "hit,hd44780";
+ data-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>,
+ <&gpio1 1 GPIO_ACTIVE_HIGH>,
+ <&gpio1 3 GPIO_ACTIVE_HIGH>,
+ <&gpio1 17 GPIO_ACTIVE_HIGH>;
+ enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
+ rs-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
+ rw-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
+ backlight-gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
+ display-height-chars = <2>;
+ display-width-chars = <16>;
+ };
+
gpio-leds {
compatible = "gpio-leds";
pinctrl-0 = < &pmx_led_blue_power &pmx_led_blue_backup
--
2.26.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm/dts: Add DT block for Netgear ReadyNAS NV+ v2 LCD panel
2020-04-25 2:24 [PATCH] arm/dts: Add DT block for Netgear ReadyNAS NV+ v2 LCD panel Brian J. Tarricone
@ 2020-04-25 14:27 ` Andrew Lunn
2020-04-25 19:28 ` [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add " Brian J. Tarricone
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2020-04-25 14:27 UTC (permalink / raw)
To: Brian J. Tarricone
Cc: gregory.clement, jason, linux-arm-kernel, sebastian.hesselbarth
On Fri, Apr 24, 2020 at 07:24:09PM -0700, Brian J. Tarricone wrote:
> The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
> similar to the Netgear RN104, just with different GPIO assignments.
>
> Signed-off-by: Brian J. Tarricone <brian@tarricone.org>
Hi Brian
The change itself looks O.K.
However, please could you change the subject to follow what other
kirkwood DT patches use:
arch/arm/boot/dts$ git log --oneline kirkwood-*
15382b7ea298 ARM: dts: kirkwood: synology: Fix rs5c372 RTC entry
644763224169 ARM: dts: kirkwood: ts219: disable the SoC's RTC
6a3b25173cd4 arch: arm: dts: kirkwood-rd88f6281: Remove disabled marvell,dsa reference
cb92e40411ef arch: arm: dts: Remove disabled marvell,dsa properties
b5f034845e70 ARM: dts: kirkwood: Fix polarity of GPIO fan lines
eb59e0920331 arm: dts: kirkwood*.dts: use SPDX-License-Identifier for board using GPL-2.0+
b3820aa10c1b arm: dts: kirkwood*.dts: use SPDX-License-Identifier for boards using GPL-2.0+/MIT
e7822263a7a5 arm: dts: kirkwood*.dts: use SPDX-License-Identifier for boards using GPL-2.0
5beaf4d7ce9e ARM: dts: kirkwood: Fix "debounce-interval" property misspelling
Yes, there is a bit of variance, but something like
ARM: dts: kirkwood: Readynas nv2: Add LCD panel
Thanks
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add LCD panel
2020-04-25 14:27 ` Andrew Lunn
@ 2020-04-25 19:28 ` Brian J. Tarricone
2020-04-25 20:14 ` Andrew Lunn
2020-05-17 16:52 ` Gregory CLEMENT
0 siblings, 2 replies; 5+ messages in thread
From: Brian J. Tarricone @ 2020-04-25 19:28 UTC (permalink / raw)
To: linux-arm-kernel
Cc: andrew, gregory.clement, Brian J. Tarricone, jason,
sebastian.hesselbarth
The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
similar to the Netgear RN104, just with different GPIO assignments.
Signed-off-by: Brian J. Tarricone <brian@tarricone.org>
---
.../boot/dts/kirkwood-netgear_readynas_nv+_v2.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
index 8cc8550242ef..b13aee570804 100644
--- a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
+++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
@@ -113,6 +113,20 @@ sata@80000 { /* Connected to Marvell 88SM4140 SATA port multiplier */
};
};
+ auxdisplay {
+ compatible = "hit,hd44780";
+ data-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>,
+ <&gpio1 1 GPIO_ACTIVE_HIGH>,
+ <&gpio1 3 GPIO_ACTIVE_HIGH>,
+ <&gpio1 17 GPIO_ACTIVE_HIGH>;
+ enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
+ rs-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
+ rw-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
+ backlight-gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
+ display-height-chars = <2>;
+ display-width-chars = <16>;
+ };
+
gpio-leds {
compatible = "gpio-leds";
pinctrl-0 = < &pmx_led_blue_power &pmx_led_blue_backup
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add LCD panel
2020-04-25 19:28 ` [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add " Brian J. Tarricone
@ 2020-04-25 20:14 ` Andrew Lunn
2020-05-17 16:52 ` Gregory CLEMENT
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2020-04-25 20:14 UTC (permalink / raw)
To: Brian J. Tarricone
Cc: gregory.clement, jason, linux-arm-kernel, sebastian.hesselbarth
On Sat, Apr 25, 2020 at 12:28:20PM -0700, Brian J. Tarricone wrote:
> The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
> similar to the Netgear RN104, just with different GPIO assignments.
>
> Signed-off-by: Brian J. Tarricone <brian@tarricone.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Hi Brian
FYI: Since this is the second version, the Subject: should be:
[PATCH v2] ARM: dts: kirkwood: ReadyNAS NV+v2: Add LCD panel
It helps us keep track of which is the last version and so should be
merged. No need to repost, but please try to remember for future
patches you submit.
Thanks
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add LCD panel
2020-04-25 19:28 ` [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add " Brian J. Tarricone
2020-04-25 20:14 ` Andrew Lunn
@ 2020-05-17 16:52 ` Gregory CLEMENT
1 sibling, 0 replies; 5+ messages in thread
From: Gregory CLEMENT @ 2020-05-17 16:52 UTC (permalink / raw)
To: Brian J. Tarricone, linux-arm-kernel
Cc: andrew, Brian J. Tarricone, jason, sebastian.hesselbarth
Hi Brian,
> The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
> similar to the Netgear RN104, just with different GPIO assignments.
>
> Signed-off-by: Brian J. Tarricone <brian@tarricone.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> .../boot/dts/kirkwood-netgear_readynas_nv+_v2.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
> index 8cc8550242ef..b13aee570804 100644
> --- a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
> +++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
> @@ -113,6 +113,20 @@ sata@80000 { /* Connected to Marvell 88SM4140 SATA port multiplier */
> };
> };
>
> + auxdisplay {
> + compatible = "hit,hd44780";
> + data-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>,
> + <&gpio1 1 GPIO_ACTIVE_HIGH>,
> + <&gpio1 3 GPIO_ACTIVE_HIGH>,
> + <&gpio1 17 GPIO_ACTIVE_HIGH>;
> + enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> + rs-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> + rw-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
> + backlight-gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
> + display-height-chars = <2>;
> + display-width-chars = <16>;
> + };
> +
> gpio-leds {
> compatible = "gpio-leds";
> pinctrl-0 = < &pmx_led_blue_power &pmx_led_blue_backup
> --
> 2.26.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-17 16:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-25 2:24 [PATCH] arm/dts: Add DT block for Netgear ReadyNAS NV+ v2 LCD panel Brian J. Tarricone
2020-04-25 14:27 ` Andrew Lunn
2020-04-25 19:28 ` [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add " Brian J. Tarricone
2020-04-25 20:14 ` Andrew Lunn
2020-05-17 16:52 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).