From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Fri, 28 Aug 2015 10:49:36 +0200 Subject: [PATCH v2 11/21] ARM: pxa: magician: Add MAX1586 Vcore regulator support In-Reply-To: <55D655C5.40506@tul.cz> (Petr Cvek's message of "Fri, 21 Aug 2015 00:33:41 +0200") References: <55D259CC.6040307@tul.cz> <87pp2h69iy.fsf@belgarion.home> <55D655C5.40506@tul.cz> Message-ID: <87613z3ihr.fsf@belgarion.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Petr Cvek writes: > Dne 20.8.2015 v 21:32 Robert Jarzmik napsal(a): >> Petr Cvek writes: >> >>> Add support for MAX1586 Vcore regulator. >>> >>> Signed-off-by: Petr Cvek >> I'll leave that for a week and if no objections queue it. >> >> I would have expected a better commit message : for example, from your patch I >> deduce magician has a 1587 regulator, not a 1586 one : that deserves a small >> mention in the commit message. Moreover, the Maxim has 2 outputs : one is >> connected to VCC_Core of the SoC, what about the other output ? Is it unknown, >> or do you know but don't use it ? >> > You mean V6 - Usim? MAX1587 does not have this pin implemented. I will note it > in commit message. Excellent, thanks. Cheers. -- Robert