From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] ARM: OMAP: dma: Make use of cpu_class_is_omap2() to avoid future patching.
Date: Thu, 03 May 2012 14:47:53 -0700 [thread overview]
Message-ID: <8762cdgcmu.fsf@ti.com> (raw)
In-Reply-To: <1335952093-12541-5-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Wed, 2 May 2012 15:18:10 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> cpu_class_is_omap2() contains all OMAP2+ devices. So update the DMA code
> cpu checks accordingly so that there is no need to patch
> the file for any future OMAP2+ devices.
>
> In long run, all these attributes should come from hwmod dev_attr based
> on DMA IP version.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mach-omap2/dma.c | 2 +-
> arch/arm/plat-omap/dma.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index b19d849..2750bb9 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
>
> dma_stride = OMAP2_DMA_STRIDE;
> dma_common_ch_start = CSDP;
> - if (cpu_is_omap3630() || cpu_is_omap44xx())
> + if (omap_rev() >= OMAP3630_REV_ES1_0)
It's not obvious (at least to me) that this is equivalent.
For example, this will now be true on the TI81xx devices.
Kevin
next prev parent reply other threads:[~2012-05-03 21:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 9:48 [PATCH 0/7] ARM: OMAP2+: Misc cleanup Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 1/7] ARM: OMAP4: Don't compile cm2xxx_3xxx.c for OMAP4 only builds Santosh Shilimkar
2012-05-08 5:09 ` Paul Walmsley
2012-05-08 6:09 ` Shilimkar, Santosh
2012-05-02 9:48 ` [PATCH 2/7] ARM: OMAP2+: Clean up wrapping multiple objects in Makefile Santosh Shilimkar
2012-05-02 9:56 ` Russell King - ARM Linux
2012-05-02 10:14 ` Shilimkar, Santosh
2012-05-02 15:49 ` Tony Lindgren
2012-05-02 9:48 ` [PATCH 3/7] ARM: OMAP4: Remove un-used WakeupGen register defines Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 4/7] ARM: OMAP: dma: Make use of cpu_class_is_omap2() to avoid future patching Santosh Shilimkar
2012-05-03 21:47 ` Kevin Hilman [this message]
2012-05-04 7:04 ` Shilimkar, Santosh
2012-05-04 16:46 ` Kevin Hilman
2012-05-02 9:48 ` [PATCH 5/7] ARM: All OMAP2PLUS machines use omap2 directory so just add one entry Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 6/7] ARM: OMAP4: Reduce the static IO mapping Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 7/7] ARM: OMAP4+: Add prm and cm base init function Santosh Shilimkar
2012-05-08 5:15 ` Paul Walmsley
2012-05-08 6:13 ` Shilimkar, Santosh
2012-05-07 23:03 ` [PATCH 0/7] ARM: OMAP2+: Misc cleanup Tony Lindgren
2012-05-08 7:17 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762cdgcmu.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).