From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Thu, 03 May 2012 14:47:53 -0700 Subject: [PATCH 4/7] ARM: OMAP: dma: Make use of cpu_class_is_omap2() to avoid future patching. In-Reply-To: <1335952093-12541-5-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Wed, 2 May 2012 15:18:10 +0530") References: <1335952093-12541-1-git-send-email-santosh.shilimkar@ti.com> <1335952093-12541-5-git-send-email-santosh.shilimkar@ti.com> Message-ID: <8762cdgcmu.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Santosh Shilimkar writes: > cpu_class_is_omap2() contains all OMAP2+ devices. So update the DMA code > cpu checks accordingly so that there is no need to patch > the file for any future OMAP2+ devices. > > In long run, all these attributes should come from hwmod dev_attr based > on DMA IP version. > > Signed-off-by: Santosh Shilimkar > --- > arch/arm/mach-omap2/dma.c | 2 +- > arch/arm/plat-omap/dma.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c > index b19d849..2750bb9 100644 > --- a/arch/arm/mach-omap2/dma.c > +++ b/arch/arm/mach-omap2/dma.c > @@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused) > > dma_stride = OMAP2_DMA_STRIDE; > dma_common_ch_start = CSDP; > - if (cpu_is_omap3630() || cpu_is_omap44xx()) > + if (omap_rev() >= OMAP3630_REV_ES1_0) It's not obvious (at least to me) that this is equivalent. For example, this will now be true on the TI81xx devices. Kevin