From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] OMAP: omap_device: only override _noirq methods, not normal suspend/resume
Date: Thu, 01 Sep 2011 10:50:24 -0700 [thread overview]
Message-ID: <8762lcf8yn.fsf@ti.com> (raw)
In-Reply-To: <201109011800.55516.arnd@arndb.de> (Arnd Bergmann's message of "Thu, 1 Sep 2011 18:00:55 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> On Thursday 25 August 2011, Kevin Hilman wrote:
>> --- a/arch/arm/plat-omap/omap_device.c
>> +++ b/arch/arm/plat-omap/omap_device.c
>> @@ -622,7 +622,8 @@ static struct dev_pm_domain omap_device_pm_domain = {
>> SET_RUNTIME_PM_OPS(_od_runtime_suspend, _od_runtime_resume,
>> _od_runtime_idle)
>> USE_PLATFORM_PM_SLEEP_OPS
>> - SET_SYSTEM_SLEEP_PM_OPS(_od_suspend_noirq, _od_resume_noirq)
>> + .suspend_noirq = _od_suspend_noirq,
>> + .resume_noirq = _od_resume_noirq,
>> }
>> };
>
> This breaks if CONFIG_SUSPEND is not set and the _od_suspend_noirq/_od_resume_noirq
> functions are not defined.
Indeed.
Will post a fix shortly.
Kevin
prev parent reply other threads:[~2011-09-01 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 23:43 [PATCH 0/1] PM: omap_device fix for v3.1-rc Kevin Hilman
2011-08-24 23:43 ` [PATCH 1/1] OMAP: omap_device: only override _noirq methods, not normal suspend/resume Kevin Hilman
2011-08-25 14:12 ` Rafael J. Wysocki
2011-09-01 16:00 ` Arnd Bergmann
2011-09-01 17:50 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762lcf8yn.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).