From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: only select sound drivers that build
Date: Tue, 19 May 2015 15:50:07 +0200 [thread overview]
Message-ID: <8763723.lDqvJa39j2@wuerfel> (raw)
In-Reply-To: <CAMuHMdWDS73aA8ottgEPYgE=FHFeOwWdEcRGEyv8LbOUU1eUgQ@mail.gmail.com>
On Tuesday 19 May 2015 15:34:00 Geert Uytterhoeven wrote:
> On Tue, May 19, 2015 at 2:49 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > A couple of codec drivers are selected by shmobile platform code,
> > but depend on I2C, which results in a build error:
>
> > --- a/arch/arm/mach-shmobile/Kconfig
> > +++ b/arch/arm/mach-shmobile/Kconfig
>
> > @@ -158,8 +158,8 @@ config MACH_BOCKW
> > depends on ARCH_R8A7778
> > select ARCH_REQUIRE_GPIOLIB
> > select REGULATOR_FIXED_VOLTAGE if REGULATOR
> > - select SND_SOC_AK4554 if SND_SIMPLE_CARD
> > - select SND_SOC_AK4642 if SND_SIMPLE_CARD
> > + select SND_SOC_AK4554 if SND_SIMPLE_CARD && I2C
>
> AK4554 is not an i2c device, but a plain platform device.
>
> > + select SND_SOC_AK4642 if SND_SIMPLE_CARD && I2C
> > select USE_OF
>
> The others are OK, so if you have remove AK4554, you can add my
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>
Ah, my mistake. I've sent a fixed version 2 now.
Thanks!
Arnd
next prev parent reply other threads:[~2015-05-19 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 12:49 [PATCH] ARM: shmobile: only select sound drivers that build Arnd Bergmann
2015-05-19 13:34 ` Geert Uytterhoeven
2015-05-19 13:50 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-05-28 1:05 [GIT PULL] Renesas ARM Based SoC Updates for v4.2 Simon Horman
2015-05-28 1:05 ` [PATCH] ARM: shmobile: only select sound drivers that build Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763723.lDqvJa39j2@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox