Re: [ISSUE + PATCH] Interrupts were enabled early by spinlock guard

Nicolas Ferre
2025-08-25T14:59:00Z

On 14/08/2025 at 17:28, Edgar Bonet wrote:
> Hello Geert, and thanks for you prompt review!

Yep, Geert, many thanks!

>> I think the conversions in
>> drivers/irqchip/irq-atmel-aic.c:aic_irq_domain_xlate() and
>> drivers/irqchip/irq-loongson-liointc.c:liointc_set_type()
>> are also wrong, and need a similar change.
>
> The one in irq-atmel-aic.c looks indeed strikingly similar. The one in
> irq-loongson-liointc.c is slightly different though. Instead of:
>
> irq_gc_lock_irqsave() -> guard(raw_spinlock_irq)
>
> it does:
>
> irq_gc_lock_irqsave() -> guard(raw_spinlock)
>
> I don't know what the implications are though.
>
>> Unfortunately I have no hardware to verify.
>
> Neither do I.

I'm on it. Expect feedback later today...
Thanks so much for the heads-up.

Best regards,
Nicolas