From: Marc Zyngier <maz@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: patches@lists.linux.dev, stable@vger.kernel.org,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
toan@os.amperecomputing.com, kwilczynski@kernel.org,
mani@kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 6.16-6.6] PCI: xgene-msi: Resend an MSI racing with itself on a different CPU
Date: Tue, 05 Aug 2025 19:09:40 +0100 [thread overview]
Message-ID: <877bzhtzbv.wl-maz@kernel.org> (raw)
In-Reply-To: <aJIOP1GO8LumDZOJ@lappy>
On Tue, 05 Aug 2025 14:59:27 +0100,
Sasha Levin <sashal@kernel.org> wrote:
>
> On Tue, Aug 05, 2025 at 02:20:52PM +0100, Marc Zyngier wrote:
> > On Tue, 05 Aug 2025 14:09:34 +0100,
> > Sasha Levin <sashal@kernel.org> wrote:
> >>
> >> From: Marc Zyngier <maz@kernel.org>
> >>
> >> [ Upstream commit 3cc8f625e4c6a0e9f936da6b94166e62e387fe1d ]
> >>
> >> Since changing the affinity of an MSI really is about changing
> >> the target address and that it isn't possible to mask an individual
> >> MSI, it is completely possible for an interrupt to race with itself,
> >> usually resulting in a lost interrupt.
> >>
> >> Paper over the design blunder by informing the core code of this
> >> sad state of affairs.
> >>
> >> Signed-off-by: Marc Zyngier <maz@kernel.org>
> >> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> >> Link: https://lore.kernel.org/r/20250708173404.1278635-11-maz@kernel.org
> >> Signed-off-by: Sasha Levin <sashal@kernel.org>
> >> ---
> >>
> >> LLM Generated explanations, may be completely bogus:
> >
> > s/may be//. It is an amusing read though, specially when quoting
> > totally unrelated patches, so thumbs up for the comical value.
>
> Yeah, it's still very much at the "junior engineer" level
It's not, and that's the main issue. A junior engineer would get into
the rabbit hole of backporting too much, as they would be unable to
separate the essential logic from the surrounding fluff. There would
be a lot of noise, but it would be OK.
Your "thing" is very much at the "Senior Marketroid" level, in the
sense that it manages to drag some semi-relevant information from
various sources, and condenses it into an advertisement for snake oil.
I think I know who which of the two I want to work with.
M.
--
Jazz isn't dead. It just smells funny.
prev parent reply other threads:[~2025-08-05 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250805130945.471732-1-sashal@kernel.org>
2025-08-05 13:08 ` [PATCH AUTOSEL 6.16-5.4] pinctrl: stm32: Manage irq affinity settings Sasha Levin
2025-08-05 13:08 ` [PATCH AUTOSEL 6.16] PCI: dw-rockchip: Delay link training after hot reset in EP mode Sasha Levin
2025-08-05 13:08 ` [PATCH AUTOSEL 6.16-6.6] phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal Sasha Levin
2025-08-05 13:08 ` [PATCH AUTOSEL 6.16-6.15] media: raspberrypi: cfe: Fix min_reqbufs_allocation Sasha Levin
2025-08-05 13:09 ` [PATCH AUTOSEL 6.16-6.15] phy: rockchip-pcie: Enable all four lanes if required Sasha Levin
2025-08-05 13:09 ` [PATCH AUTOSEL 6.16-6.1] dmaengine: stm32-dma: configure next sg only if there are more than 2 sgs Sasha Levin
2025-08-05 13:09 ` [PATCH AUTOSEL 6.16-6.6] PCI: xgene-msi: Resend an MSI racing with itself on a different CPU Sasha Levin
2025-08-05 13:20 ` Marc Zyngier
2025-08-05 13:59 ` Sasha Levin
2025-08-05 18:09 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bzhtzbv.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).