[PATCH] dt-binding: thermal: Convert marvell,armada-ap806-thermal to DT schema

[PATCH] dt-binding: thermal: Convert marvell,armada-ap806-thermal to DT schema

[Rob Herring (Arm)]

Convert the Marvell Armada AP80x/CP110 thermal binding to schema. It is
a straight forward conversion.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../arm/marvell/ap80x-system-controller.txt   | 39 ----------------
 .../arm/marvell/cp110-system-controller.txt   | 43 ------------------
 .../thermal/marvell,armada-ap806-thermal.yaml | 44 +++++++++++++++++++
 3 files changed, 44 insertions(+), 82 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml

diff --git a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
index c83245065d44..72de11bd2ef0 100644
--- a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
+++ b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
@@ -115,45 +115,6 @@ ap_syscon: system-controller@6f4000 {
 SYSTEM CONTROLLER 1
 ===================
 
-Thermal:
---------
-
-For common binding part and usage, refer to
-Documentation/devicetree/bindings/thermal/thermal*.yaml
-
-The thermal IP can probe the temperature all around the processor. It
-may feature several channels, each of them wired to one sensor.
-
-It is possible to setup an overheat interrupt by giving at least one
-critical point to any subnode of the thermal-zone node.
-
-Required properties:
-- compatible: must be one of:
-  * marvell,armada-ap806-thermal
-- reg: register range associated with the thermal functions.
-
-Optional properties:
-- interrupts: overheat interrupt handle. Should point to line 18 of the
-  SEI irqchip. See interrupt-controller/interrupts.txt
-- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer
-  to this IP and represents the channel ID. There is one sensor per
-  channel. O refers to the thermal IP internal channel, while positive
-  IDs refer to each CPU.
-
-Example:
-ap_syscon1: system-controller@6f8000 {
-	compatible = "syscon", "simple-mfd";
-	reg = <0x6f8000 0x1000>;
-
-	ap_thermal: thermal-sensor@80 {
-		compatible = "marvell,armada-ap806-thermal";
-		reg = <0x80 0x10>;
-		interrupt-parent = <&sei>;
-		interrupts = <18>;
-		#thermal-sensor-cells = <1>;
-	};
-};
-
 Cluster clocks:
 ---------------
 
diff --git a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
index 9d5d70c98058..54ff9f218328 100644
--- a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
+++ b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
@@ -189,46 +189,3 @@ CP110_LABEL(syscon0): system-controller@440000 {
 	};
 
 };
-
-SYSTEM CONTROLLER 1
-===================
-
-Thermal:
---------
-
-The thermal IP can probe the temperature all around the processor. It
-may feature several channels, each of them wired to one sensor.
-
-It is possible to setup an overheat interrupt by giving at least one
-critical point to any subnode of the thermal-zone node.
-
-For common binding part and usage, refer to
-Documentation/devicetree/bindings/thermal/thermal*.yaml
-
-Required properties:
-- compatible: must be one of:
-  * marvell,armada-cp110-thermal
-- reg: register range associated with the thermal functions.
-
-Optional properties:
-- interrupts-extended: overheat interrupt handle. Should point to
-  a line of the ICU-SEI irqchip (116 is what is usually used by the
-  firmware). The ICU-SEI will redirect towards interrupt line #37 of the
-  AP SEI which is shared across all CPs.
-  See interrupt-controller/interrupts.txt
-- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer
-  to this IP and represents the channel ID. There is one sensor per
-  channel. O refers to the thermal IP internal channel.
-
-Example:
-CP110_LABEL(syscon1): system-controller@6f8000 {
-	compatible = "syscon", "simple-mfd";
-	reg = <0x6f8000 0x1000>;
-
-	CP110_LABEL(thermal): thermal-sensor@70 {
-		compatible = "marvell,armada-cp110-thermal";
-		reg = <0x70 0x10>;
-		interrupts-extended = <&CP110_LABEL(icu_sei) 116 IRQ_TYPE_LEVEL_HIGH>;
-		#thermal-sensor-cells = <1>;
-	};
-};
diff --git a/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml
new file mode 100644
index 000000000000..fdbdf3c1273a
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/marvell,armada-ap806-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Armada AP80x/CP110 thermal management
+
+maintainers:
+  - Miquel Raynal <miquel.raynal@bootlin.com>
+
+properties:
+  compatible:
+    enum:
+      - marvell,armada-ap806-thermal
+      - marvell,armada-ap807-thermal
+      - marvell,armada-cp110-thermal
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description: overheat interrupt
+    maxItems: 1
+
+  '#thermal-sensor-cells':
+    description: Cell represents the channel ID. There is one sensor per
+      channel. O refers to the thermal IP internal channel.
+    const: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    thermal-sensor@80 {
+        compatible = "marvell,armada-ap806-thermal";
+        reg = <0x80 0x10>;
+        interrupts = <18>;
+        #thermal-sensor-cells = <1>;
+    };
-- 
2.47.2

Re: [PATCH] dt-binding: thermal: Convert marvell,armada-ap806-thermal to DT schema

[Rob Herring]

On Wed, Jul 02, 2025 at 06:00:29PM -0500, Rob Herring (Arm) wrote:
> Convert the Marvell Armada AP80x/CP110 thermal binding to schema. It is
> a straight forward conversion.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../arm/marvell/ap80x-system-controller.txt   | 39 ----------------
>  .../arm/marvell/cp110-system-controller.txt   | 43 ------------------
>  .../thermal/marvell,armada-ap806-thermal.yaml | 44 +++++++++++++++++++
>  3 files changed, 44 insertions(+), 82 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml

Ping!

> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
> index c83245065d44..72de11bd2ef0 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
> @@ -115,45 +115,6 @@ ap_syscon: system-controller@6f4000 {
>  SYSTEM CONTROLLER 1
>  ===================
>  
> -Thermal:
> ---------
> -
> -For common binding part and usage, refer to
> -Documentation/devicetree/bindings/thermal/thermal*.yaml
> -
> -The thermal IP can probe the temperature all around the processor. It
> -may feature several channels, each of them wired to one sensor.
> -
> -It is possible to setup an overheat interrupt by giving at least one
> -critical point to any subnode of the thermal-zone node.
> -
> -Required properties:
> -- compatible: must be one of:
> -  * marvell,armada-ap806-thermal
> -- reg: register range associated with the thermal functions.
> -
> -Optional properties:
> -- interrupts: overheat interrupt handle. Should point to line 18 of the
> -  SEI irqchip. See interrupt-controller/interrupts.txt
> -- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer
> -  to this IP and represents the channel ID. There is one sensor per
> -  channel. O refers to the thermal IP internal channel, while positive
> -  IDs refer to each CPU.
> -
> -Example:
> -ap_syscon1: system-controller@6f8000 {
> -	compatible = "syscon", "simple-mfd";
> -	reg = <0x6f8000 0x1000>;
> -
> -	ap_thermal: thermal-sensor@80 {
> -		compatible = "marvell,armada-ap806-thermal";
> -		reg = <0x80 0x10>;
> -		interrupt-parent = <&sei>;
> -		interrupts = <18>;
> -		#thermal-sensor-cells = <1>;
> -	};
> -};
> -
>  Cluster clocks:
>  ---------------
>  
> diff --git a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
> index 9d5d70c98058..54ff9f218328 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
> @@ -189,46 +189,3 @@ CP110_LABEL(syscon0): system-controller@440000 {
>  	};
>  
>  };
> -
> -SYSTEM CONTROLLER 1
> -===================
> -
> -Thermal:
> ---------
> -
> -The thermal IP can probe the temperature all around the processor. It
> -may feature several channels, each of them wired to one sensor.
> -
> -It is possible to setup an overheat interrupt by giving at least one
> -critical point to any subnode of the thermal-zone node.
> -
> -For common binding part and usage, refer to
> -Documentation/devicetree/bindings/thermal/thermal*.yaml
> -
> -Required properties:
> -- compatible: must be one of:
> -  * marvell,armada-cp110-thermal
> -- reg: register range associated with the thermal functions.
> -
> -Optional properties:
> -- interrupts-extended: overheat interrupt handle. Should point to
> -  a line of the ICU-SEI irqchip (116 is what is usually used by the
> -  firmware). The ICU-SEI will redirect towards interrupt line #37 of the
> -  AP SEI which is shared across all CPs.
> -  See interrupt-controller/interrupts.txt
> -- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer
> -  to this IP and represents the channel ID. There is one sensor per
> -  channel. O refers to the thermal IP internal channel.
> -
> -Example:
> -CP110_LABEL(syscon1): system-controller@6f8000 {
> -	compatible = "syscon", "simple-mfd";
> -	reg = <0x6f8000 0x1000>;
> -
> -	CP110_LABEL(thermal): thermal-sensor@70 {
> -		compatible = "marvell,armada-cp110-thermal";
> -		reg = <0x70 0x10>;
> -		interrupts-extended = <&CP110_LABEL(icu_sei) 116 IRQ_TYPE_LEVEL_HIGH>;
> -		#thermal-sensor-cells = <1>;
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml
> new file mode 100644
> index 000000000000..fdbdf3c1273a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/marvell,armada-ap806-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Armada AP80x/CP110 thermal management
> +
> +maintainers:
> +  - Miquel Raynal <miquel.raynal@bootlin.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - marvell,armada-ap806-thermal
> +      - marvell,armada-ap807-thermal
> +      - marvell,armada-cp110-thermal
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description: overheat interrupt
> +    maxItems: 1
> +
> +  '#thermal-sensor-cells':
> +    description: Cell represents the channel ID. There is one sensor per
> +      channel. O refers to the thermal IP internal channel.
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    thermal-sensor@80 {
> +        compatible = "marvell,armada-ap806-thermal";
> +        reg = <0x80 0x10>;
> +        interrupts = <18>;
> +        #thermal-sensor-cells = <1>;
> +    };
> -- 
> 2.47.2
> 

Re: [PATCH] dt-binding: thermal: Convert marvell,armada-ap806-thermal to DT schema

[Miquel Raynal]

Hi Rob,

Sorry for the delay, I don't know why I forgot these.

...

> +properties:
> +  compatible:
> +    enum:
> +      - marvell,armada-ap806-thermal
> +      - marvell,armada-ap807-thermal
> +      - marvell,armada-cp110-thermal
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description: overheat interrupt
> +    maxItems: 1
> +
> +  '#thermal-sensor-cells':
> +    description: Cell represents the channel ID. There is one sensor per
> +      channel. O refers to the thermal IP internal channel.
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

IIRC on these Marvell designs, there was one (or more, I don't remember)
Application Processor (AP) and several Co-Processors (CP).

[On the AP]
The AP8XX overheat interrupt was not directly wired to the GIC but was
going through another intermediate IRQ controller named SEI (System
Error Interrupt).

      Thermal overheat IRQ -> SEI -> GIC

[On the CP]
There was one interrupt controller per CP11X named ICU, which would be
connected to the top level GIC through MSIs. The ICU was however split
into several sub-controllers reaching different areas on the GIC.

                                      MSI
      Thermal overheat IRQ -> ICU SEI -> GIC

As the OS could not guess the internal connexions, I believe we had to
include in the bindings the parent IRQ chip we were connected to. In the
case of the thermal over heat interrupts, they were all going through an
SEI controller (System Error Interrupt) which, if I still remember
correctly, was not the default parent, hence the use of
interrupts-parent/interrupts-extended in the examples.

This is all a bit cloudy in my mind, but I believe these properties
matter and with 'additionalProperties: false' and without
interrupts-parent/interrupts-extended allowed, a real world DT
snippet would not pass the binding checks.

> +examples:
> +  - |
> +    thermal-sensor@80 {
> +        compatible = "marvell,armada-ap806-thermal";
> +        reg = <0x80 0x10>;
> +        interrupts = <18>;

I do not know how accurate the example must be, but maybe the example
shall reflect the SEI connection as well.

> +        #thermal-sensor-cells = <1>;
> +    };

Thanks,
Miquèl

Re: [PATCH] dt-binding: thermal: Convert marvell,armada-ap806-thermal to DT schema

[Rob Herring]

On Fri, Aug 1, 2025 at 9:27 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Rob,
>
> Sorry for the delay, I don't know why I forgot these.
>
> ...
>
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - marvell,armada-ap806-thermal
> > +      - marvell,armada-ap807-thermal
> > +      - marvell,armada-cp110-thermal
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    description: overheat interrupt
> > +    maxItems: 1
> > +
> > +  '#thermal-sensor-cells':
> > +    description: Cell represents the channel ID. There is one sensor per
> > +      channel. O refers to the thermal IP internal channel.
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
>
> IIRC on these Marvell designs, there was one (or more, I don't remember)
> Application Processor (AP) and several Co-Processors (CP).
>
> [On the AP]
> The AP8XX overheat interrupt was not directly wired to the GIC but was
> going through another intermediate IRQ controller named SEI (System
> Error Interrupt).
>
>       Thermal overheat IRQ -> SEI -> GIC
>
> [On the CP]
> There was one interrupt controller per CP11X named ICU, which would be
> connected to the top level GIC through MSIs. The ICU was however split
> into several sub-controllers reaching different areas on the GIC.
>
>                                       MSI
>       Thermal overheat IRQ -> ICU SEI -> GIC
>
> As the OS could not guess the internal connexions, I believe we had to
> include in the bindings the parent IRQ chip we were connected to. In the
> case of the thermal over heat interrupts, they were all going through an
> SEI controller (System Error Interrupt) which, if I still remember
> correctly, was not the default parent, hence the use of
> interrupts-parent/interrupts-extended in the examples.
>
> This is all a bit cloudy in my mind, but I believe these properties
> matter and with 'additionalProperties: false' and without
> interrupts-parent/interrupts-extended allowed, a real world DT
> snippet would not pass the binding checks.

'interrupt-parent' is implicitly allowed anywhere. Who is the parent
is outside the scope of the binding given it can vary.

> > +examples:
> > +  - |
> > +    thermal-sensor@80 {
> > +        compatible = "marvell,armada-ap806-thermal";
> > +        reg = <0x80 0x10>;
> > +        interrupts = <18>;
>
> I do not know how accurate the example must be, but maybe the example
> shall reflect the SEI connection as well.

No one has cared about converting the Marvell bindings, so *shrug*.

Really, the whole example should be deleted when/if the parent is
properly documented.

Rob

Re: [PATCH] dt-binding: thermal: Convert marvell,armada-ap806-thermal to DT schema

[Miquel Raynal]

On 01/08/2025 at 15:22:20 -05, Rob Herring <robh@kernel.org> wrote:

> On Fri, Aug 1, 2025 at 9:27 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>>
>> Hi Rob,
>>
>> Sorry for the delay, I don't know why I forgot these.
>>
>> ...
>>
>> > +properties:
>> > +  compatible:
>> > +    enum:
>> > +      - marvell,armada-ap806-thermal
>> > +      - marvell,armada-ap807-thermal
>> > +      - marvell,armada-cp110-thermal
>> > +
>> > +  reg:
>> > +    maxItems: 1
>> > +
>> > +  interrupts:
>> > +    description: overheat interrupt
>> > +    maxItems: 1
>> > +
>> > +  '#thermal-sensor-cells':
>> > +    description: Cell represents the channel ID. There is one sensor per
>> > +      channel. O refers to the thermal IP internal channel.
>> > +    const: 1
>> > +
>> > +required:
>> > +  - compatible
>> > +  - reg
>> > +
>> > +additionalProperties: false
>>
>> IIRC on these Marvell designs, there was one (or more, I don't remember)
>> Application Processor (AP) and several Co-Processors (CP).
>>
>> [On the AP]
>> The AP8XX overheat interrupt was not directly wired to the GIC but was
>> going through another intermediate IRQ controller named SEI (System
>> Error Interrupt).
>>
>>       Thermal overheat IRQ -> SEI -> GIC
>>
>> [On the CP]
>> There was one interrupt controller per CP11X named ICU, which would be
>> connected to the top level GIC through MSIs. The ICU was however split
>> into several sub-controllers reaching different areas on the GIC.
>>
>>                                       MSI
>>       Thermal overheat IRQ -> ICU SEI -> GIC
>>
>> As the OS could not guess the internal connexions, I believe we had to
>> include in the bindings the parent IRQ chip we were connected to. In the
>> case of the thermal over heat interrupts, they were all going through an
>> SEI controller (System Error Interrupt) which, if I still remember
>> correctly, was not the default parent, hence the use of
>> interrupts-parent/interrupts-extended in the examples.
>>
>> This is all a bit cloudy in my mind, but I believe these properties
>> matter and with 'additionalProperties: false' and without
>> interrupts-parent/interrupts-extended allowed, a real world DT
>> snippet would not pass the binding checks.
>
> 'interrupt-parent' is implicitly allowed anywhere. Who is the parent
> is outside the scope of the binding given it can vary.

Ok, good to know.

>> > +examples:
>> > +  - |
>> > +    thermal-sensor@80 {
>> > +        compatible = "marvell,armada-ap806-thermal";
>> > +        reg = <0x80 0x10>;
>> > +        interrupts = <18>;
>>
>> I do not know how accurate the example must be, but maybe the example
>> shall reflect the SEI connection as well.
>
> No one has cared about converting the Marvell bindings, so *shrug*.

I was still mentioning the same interrupt-parent property here ("the SEI
connection"), not how accurate the values were. So if we do not care
about interrupt-parent because it is allowed anyway,

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks for the conversion,
Miquèl