From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97341CDB47E for ; Wed, 18 Oct 2023 08:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OzuvBbESiWuNt3ceXAMegybzi5gQ9uBfypt+saOz6Ug=; b=b/ZZrNOSrRqCXj Z5w+uTCrWSnNA+otuEFw2xX0MoQGsNVEetVb7fbocXD04aE2yKxynk2x5hJVUjXTMOTMTmgMdKBik Q4prSmBzbzygL+gxE/2vCSDbEhzYoCZXXuW55BkCoKJDKqiMb1CdoAuy3JmPDTP7EaR72f1K2ckw8 l7dGqlZ57/yvW38CgR89ftb2vkSaqe8TkXzJ+NUB+bFsbIpj+WA1kHdL1aNfe60OZEyCq79yepZ6O I1AmGtSNJZ7IebNnsTSVMV3QO15NNDug6eqaqaAI3edD13dGpyuT5Iy16TJx68yXDbL3zdEvWTMAB I7fU3LciZvZM9Riam+sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt1sM-00E8hq-20; Wed, 18 Oct 2023 08:25:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt1sJ-00E8gi-2v for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 08:25:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697617554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LjzSocfdAfDkrBURoH/UDEiTk7o5qnArVSGlXdT8TDY=; b=Gszl/g/6AeKkrdq8G3YAv5rix143Hx8EHVhPbgVaaiEXsUbT1l5FVvofbZKL4Ix/UlqEyG mSHlaRDlzCMld+9taBgXx9bNeHpjBtp1YWNWTzgntczAB1nO6pZPPYXYlBMo+cETm3JPgs 89qa+od0hqNvXPur8CnoBRmCEWUJvuA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-VW_dlIQBP16GR2OSeqe_Wg-1; Wed, 18 Oct 2023 04:25:45 -0400 X-MC-Unique: VW_dlIQBP16GR2OSeqe_Wg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-32d931872cbso3634478f8f.0 for ; Wed, 18 Oct 2023 01:25:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697617544; x=1698222344; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LjzSocfdAfDkrBURoH/UDEiTk7o5qnArVSGlXdT8TDY=; b=NTded0GH45phLSTetsSCaMDyECdqqxuXpFB/BtJ+6qZFu0CZ7E9birVXIxrrFE+5LG 7qGrz5XQ+kQWZLfPo5epmclkTdllh+ohQrR+l3ID1bELNvyp3nq2XbEqzLWGwK+2savJ U2+wnw6DcwdIb2xw35R2UhMGYTp8nNv99gzRxbmM8MFww7vFzdOFr8fe3G8+WnSKZeNP yDPPxeTVWKROwY9kr/qlFlrWWEbPu78aXV6iLwAu1OdO+6Mmq0W0LuQ23YEAWHUJpc7d Yj7pmGcZSZN9RtDBJZru/XOjUc019dfSscCp67nBOdt+T+AFCs/8/27cqaSk4fO+r4Mw 6OMA== X-Gm-Message-State: AOJu0Yw/1tTJOEviZwV2qp0cteO7B9UpwISv0eBJCLz/U9hFDcI1bob9 bTMmJlbvFmn7SnZ69v8lBuP4qwV0D0wKiVuxddp0Xl9lijjfP7xGgOEsAT8noUdhaZLLcQZ8/bA bQWfG0U4ROU1MMQUHmpAD+IuXwW9jplfdHrKIz0bGHuk= X-Received: by 2002:a5d:4c89:0:b0:32d:8094:f4c8 with SMTP id z9-20020a5d4c89000000b0032d8094f4c8mr3650284wrs.19.1697617544651; Wed, 18 Oct 2023 01:25:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHa4Q8xItiTztaLFOsH4D6hLMKERtw9q396FzIJnVUMQIU6RTlte1VKHlDSYg+C3e5HZRfxSQ== X-Received: by 2002:a5d:4c89:0:b0:32d:8094:f4c8 with SMTP id z9-20020a5d4c89000000b0032d8094f4c8mr3650275wrs.19.1697617544348; Wed, 18 Oct 2023 01:25:44 -0700 (PDT) Received: from localhost (210.red-80-36-22.staticip.rima-tde.net. [80.36.22.210]) by smtp.gmail.com with ESMTPSA id j14-20020adfea4e000000b0032d81837433sm1584752wrn.30.2023.10.18.01.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 01:25:44 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , deller@gmx.de, sam@ravnborg.org, arnd@arndb.de, daniel@ffwll.ch Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-omap@vger.kernel.org, linux-parisc@vger.kernel.org, Thomas Zimmermann Subject: Re: [PATCH 00/46] fbdev: Init fb_ops with helpers for I/O memory In-Reply-To: <20230927074722.6197-1-tzimmermann@suse.de> References: <20230927074722.6197-1-tzimmermann@suse.de> Date: Wed, 18 Oct 2023 10:25:43 +0200 Message-ID: <877cnkqquw.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_012556_018900_BA989F04 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: > Initialize struct fb_ops for drivers for hardware with framebuffers > in I/O-memory ranges with the respective helper macros. Also select > the appropriate Kconfig dependencies. > > The patchset is part of a larger effort to modularize the fbdev core > and make it more adaptable. Most of these drivers do not initialize > the fb_read, fb_write and fb_mmap callbacks in fb_ops. By leaving the > callback pointers to NULL, they rely on the fbdev core to invoke the > I/O-memory helpers by default. This default makes it impossible to > remove the I/O-memory helpers on systems that don't need them. Setting > the pointers explicitly will allow for the removal of the default. If > a callback in fb_ops is unset, the operation will then be unsupported. > > Initializing struct fb_ops via helpers macros will also allow for a > fine-grained setup, depending on Kconfig options. For example, it > will be possible to leave out file I/O if FB_DEVICE has not been > set. > > This patchset contains the majority of fbdev driver work. The updated > drivers now initialize fb_ops with __FB_DEFAULT_IOMEM_OPS_RDWR, > __FB_DEFAULT_IOMEM_OPS_DRAW and/or __FB_DEFAULT_IOMEM_OPS_MMAP if > possible. Some drivers now use FB_DEFAULT_IOMEM_OPS, which sets all > fields correctly. In Kconfig, each driver selects FB_IOMEM_FOPS to > get the helpers for I/O memory. Drivers that use _RDWR, _DRAW and > _MMAP unconditionally select FB_IOMEM_HELPERS, which selects the > correct modules automatically. > I looked to all the driver changes as well and couldn't spot any issues. For all the driver patches: Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel