From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5629C61DA3 for ; Tue, 21 Feb 2023 19:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bQXq9WkugfeCtzPcansYQKj4CNrcB/t0h8edqFvxV6w=; b=swsx9KDS0OvZsW nIrhaljkokG5kUToWF9qRqarku6qv5kS7m7dQOy9ZV/DWd9xLcVaE7X7fKsByqXWMyFiO7lKXoZA4 tNrsVNpWBq1iMeT+IG3xbZWEOL0I0+EtUZ5Kt9NAN58AHBJNeDtKfZFdT0VackKZaErDiZUNC7gQY S2/78x8wM/zQgq0FkZWNreL8fTtOf/W59dsHG9mpkNSv/DpbEBouA29zZ3RM2YFX8GZ1API4IrujC jkGKo0taLeGPjlpoKHyPPVUqbpbElr0XqwxNPKvGwa8zFiF65I0GOSiBgz22hS2eCt0NW4viKjBkI sNcWlYK//GpJbY8QOSZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUYSV-009YjF-O4; Tue, 21 Feb 2023 19:37:51 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUYSS-009Yi3-Ds for linux-arm-kernel@lists.infradead.org; Tue, 21 Feb 2023 19:37:50 +0000 Received: from maxwell ([109.42.115.188]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MLRDv-1pDIgO3GwF-00ITDs; Tue, 21 Feb 2023 20:37:27 +0100 References: <87fsaz6smr.fsf@henneberg-systemdesign.com> User-agent: mu4e 1.8.14; emacs 28.2 From: Jochen Henneberg To: Simon Horman Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net V2] net: stmmac: Premature loop termination check was ignored Date: Tue, 21 Feb 2023 20:35:25 +0100 In-reply-to: Message-ID: <877cwa7qtm.fsf@henneberg-systemdesign.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:0u8rYgmp9bhY/iDXFU3B1tZaxQ+5aTcRHMJgkC1asXab22AA2cm 8hNer//gFftW5zMJmS0OGwIMpVmCTrizh0H9L7v95+b+qKKQIXQxeBWrT8uTSD+BPaqAsZ2 SxpUfRjtKZBOv9NvrIxikRZPsOt3MdG22XqRtXcn3osuHorBmsP0oeG8JViiLDRR5g39qnP Y9CIhIWvKmgS59PBH2A5Q== UI-OutboundReport: notjunk:1;M01:P0:Mg6DrOlZEeI=;wZAdP1leOOBHltclXahfqutetpA k3esz5E4vIKMIvnehBqXryrzJzasNZLFQfRiUvZIxEN+44508EOhukCXdJgDZa38zZ/Z01QCI J4z0CEPs/6pq4Fxd1RkrfuPit8ZFXUq5QmhI53VVd4FUJRCQjROm4qrj4hLIZ55B/ihXl+Iv0 XKvtYqn7jy8AXO8sxx+oOdSEiHNZmCx4LA5XaE+ULW59pqsYDQo6mSi+PBF950VvTCUKFsJ9s wgI42mvtJACdznjnOC3Byxc7XZ8zfhU27J8CE3RPvtv2IvTcJDrtkeQ5PUpegRmYMzMbrWQd1 D/7bY/aMkWo0nAbMyUS0YprMZMi4dz5rmZPd0F+FYUGQgvRMOI5jZWD7URhIdXeG5fDYWFC6I cfsH8xvpxptlbLsZ09Xx4GUr2MrqfWUK4hQ2G2SS0WZNpQai3InKMwN7XUx2ivq9pL3/0AktW I9crEuzHvWuJvfqLXARoFJLslSCkiy/fZ+6piB7q6628CwZ3oe4lld6tccTP2vlqaMhzq2ff0 uIUlqojMk7OKdPPiLEyp1XtgVFnIpptuGxqN/z4XOo0jQYZsKzZbsJu9WxQIHVM1BlfRjc8uC kJJaX7RUDf7klge2dMUEe1sh9uN9ETGLVkXWEAQU8DuqIbsrDzHbHDfZ98tTlk/zxx4jDfas6 7boqcOChDavFIJ6hLzDL1Au3beYFhEFyj+82aAcCUQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230221_113748_785197_593A801B X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The premature loop termination check makes sense only in case of the jump to read_again where the count may have been updated. But read_again did not include the check. Fixes: bba2556efad6 (net: stmmac: Enable RX via AF_XDP zero-copy) Fixes: ec222003bd94 (net: stmmac: Prepare to add Split Header support) Signed-off-by: Jochen Henneberg --- V2: Added fixes tags for both commits that introduced the issue drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 1a5b8dab5e9b..de98c009866a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue) len = 0; } +read_again: if (count >= limit) break; -read_again: buf1_len = 0; entry = next_entry; buf = &rx_q->buf_pool[entry]; @@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) len = 0; } +read_again: if (count >= limit) break; -read_again: buf1_len = 0; buf2_len = 0; entry = next_entry; -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel