From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8704AC54E94 for ; Thu, 26 Jan 2023 08:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YSZ3lyYvST35wHaz7gZwXHqyky71gpDeI3PdWj37rlk=; b=j88O34dPjZn6dq xEF6ze1oqNSwn5tpmQzxcziicGgyY/8l9rjku0TEBfR4eSmk6kZ+Qu0iXMbr0pVv14+DOTMvvHMl6 w+wZeWeJVruymiepArso4s7DPDh9S5tXUp8DMm+AFEj+cYf/Y+ieCiCLtGAyhWeCW8QIO7UOhRFA4 6MdxDRYFh7dkDv1JKXy0fnxioQgyEqdBPg8YSWzsA0Bje005uLODhejZlW8UhMwFs7EzEkOKbi4/P qxCt0cArOR3bDiNxxK+SEIlYe2ZWY1GGiZjTM0+71G6q0w/zPJNdM6+WpGfxLhmVg+amuDwiJO0qE sSpAQGIJftsI2+pwk/RA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKxyB-00A74u-FK; Thu, 26 Jan 2023 08:50:56 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKxxr-00A6uD-HU for linux-arm-kernel@lists.infradead.org; Thu, 26 Jan 2023 08:50:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2C8A61764; Thu, 26 Jan 2023 08:50:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39699C433D2; Thu, 26 Jan 2023 08:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674723034; bh=1UI1c/iYi1mNWTRN8jH3DKZP17cAXvG5BQCAwNro9Zk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fAB7UkDTUEP4QODBVcMVQhieSBeLplCGsPeZkgIkVWi90wG7fi2DnfYPgb81C17uQ EaE/wLjjyx9lu8Jbltw1cGHb6fCYR8NdT9c4Sx2dDzUwsS80jY2ML51qjmxhYNb58Z ONgMXvtA2EYAD7C/prbaGHJDw03yKtwq2XcyERIpRHJKEPwxBddOX+nrvH30Kgvj5x Nx/jsaO1w4nuSu7flPrv2bHLOtYWmNEtDtZifi19QDxHjGE802mM95uEijPtAnkODo VPKJxCQRHhbeR/vrmKEdVt0nU3E51pH5GFCaTfxxu0yktIm1ZOtXTkWX6472utjT6P iCo6vRW8H7DTw== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKxxn-004lQs-S6; Thu, 26 Jan 2023 08:50:32 +0000 Date: Thu, 26 Jan 2023 08:49:38 +0000 Message-ID: <877cx9el3x.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org Subject: Re: [PATCH v2 5/5] arm64: irqflags: use alternative branches for pseudo-NMI logic In-Reply-To: <20230125163826.496739-6-mark.rutland@arm.com> References: <20230125163826.496739-1-mark.rutland@arm.com> <20230125163826.496739-6-mark.rutland@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_005035_659972_C0FD0803 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 25 Jan 2023 16:38:26 +0000, Mark Rutland wrote: [...] > +static __always_inline void __daif_local_irq_restore(unsigned long flags) > +{ > + barrier(); > + write_sysreg(flags, daif); > + barrier(); > +} > + > +static __always_inline void __pmr_local_irq_restore(unsigned long flags) > +{ > + barrier(); > + write_sysreg_s(flags, SYS_ICC_PMR_EL1); > + pmr_sync(); > + barrier(); > +} It would be good to at least mention why we need these compile-time barriers which are not that explicit in the existing code. I guess they are equivalent to the "memory" clobber in the asm sequences that this replaces, but they don't seem to be used consistently throughout this patch. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel