From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C8C0C433FE for ; Mon, 28 Nov 2022 16:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0y6SbT2El3trd3Nni5CCy8D2Cwew08xxO2lt7LlQaPw=; b=eL3D/II3jaye1h 5WZQGpsvRevIyaaIynt3GNELevzNQhs/1GzIfQf40cTmarV/JN812Bhwdw2EKdKHMYZs9SMQmo0oL 8QAkgELdG/saaItPjq5Soz0aN664s73f8KgR/93msJEpJwwc+m9ukFJ6flQd9OcqBcOWryDeizmL6 9lf8MTkL+W0MuHRjiN8ifH9HggNJVIYXp/PNgDXcvXhdau2lH5zKf1NZ9UhGJWPWlG82ri7RUCvOM ca5R209miAifUfwRAh1teuDV7djK9rlgxjEHE1w5ai72Lgb562Dy5bMX+GPVjtiDR+GfU2S3I6ZcR I+ql8smL7yLdt1D7EeSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozh72-002qui-Vs; Mon, 28 Nov 2022 16:36:09 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozh6w-002qtG-NI for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 16:36:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669653362; x=1701189362; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bpv9EcCzKKYgtgd8XPPXyhjlOvzzWCv3x/6Nbovu2o0=; b=NlirfV5/uvCvund97uvysFnD2wIWuKHYJ2xdQ+VyvN9AeGg1kJD2AcK6 7lkKSHKIg8T0kt/Jx04hz5pjDBVyESsduejbG+f2G5jjwlLsYovpr94zF pnYjC62LsmxRrBHE8TmOXtbqkDontwaYs6ugKIlHyp+I5KouJPK1ZUoCW cLtfDiMZ4GKBuylXe3zRq/35ryLKoMkDD2cb4Ia2hWTuwKasiFpugQTPe c6Wq9l8FaDsxz+YzmjSWoet441xa5PFWBCSinFKQbrtYo430Fn4NsaVX8 WJp1jID16U12cetbgMcvc8x22hoZ136yn/OTKNgZOuOb+WVWKbZgq9fzK Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="341794103" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="341794103" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 08:35:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="674280975" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="674280975" Received: from ubik.fi.intel.com (HELO localhost) ([10.237.72.184]) by orsmga008.jf.intel.com with ESMTP; 28 Nov 2022 08:35:53 -0800 From: Alexander Shishkin To: Rob Herring , Will Deacon , Peter Zijlstra , Arnaldo Carvalho de Melo , Ingo Molnar Cc: Namhyung Kim , Jiri Olsa , Mark Rutland , Catalin Marinas , Marc Zyngier , Oliver Upton , Suzuki K Poulose , James Morse , Alexandru Elisei , kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark , Mark Brown , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, alexander.shishkin@linux.intel.com Subject: Re: [PATCH v3 7/8] perf: Add perf_event_attr::config3 In-Reply-To: References: <20220825-arm-spe-v8-7-v3-0-87682f78caac@kernel.org> <20220825-arm-spe-v8-7-v3-7-87682f78caac@kernel.org> <20221118164943.GA4872@willie-the-truck> Date: Mon, 28 Nov 2022 18:35:52 +0200 Message-ID: <877czfujdj.fsf@ubik.fi.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_083602_811771_65D6EB8E X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rob Herring writes: > On Fri, Nov 18, 2022 at 10:49 AM Will Deacon wrote: >> >> On Fri, Nov 04, 2022 at 10:55:07AM -0500, Rob Herring wrote: >> > @@ -515,6 +516,8 @@ struct perf_event_attr { >> > * truncated accordingly on 32 bit architectures. >> > */ >> > __u64 sig_data; >> > + >> > + __u64 config3; /* extension of config2 */ >> >> I need an ack from the perf core maintainers before I can take this. > > Peter, Arnaldo, Ingo, > > Can I get an ack on this please. It appears that PMUs that don't use config{1,2} and now config3 allow them to be whatever without any validation, whereas in reality we should probably -EINVAL in those cases. Should something be done about that? Regards, -- Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel