From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56BDC433EF for ; Mon, 8 Nov 2021 19:20:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F2E3617E5 for ; Mon, 8 Nov 2021 19:20:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9F2E3617E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xmission.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID: In-Reply-To:Date:References:Cc:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Jhwb1zoA3sh5/nPYERxovhCmRV1olgiRMuPhF6XOIg0=; b=LgQ9WQL3bsfTuF5nCY61Tr5K/L /TtGlyVbFgltpOBtaMSZP8nvxdb6KVPdPHjE8alnb+pjB2whKno0fINI3t6jvp3yqN6D8XOWPaxDS Rqy3STVHiLNdxiXJgSangyV09Q7NpIfVqUQskbuXnBIZTjUnulsMsHZQGGsT/PIAzyI4fRtH8amGy X0idf4mdSd75oKtFusSLk0RmOvheogPGFc1xKkhVD8/Lx5/M2PSgCcp82/R86YM30A86Wc9oQSFt/ ZiHdi3cG+vh7kH6B3bvJ9LnK3jztCWVG5WiOtJvMS0MHoW6l4YuqdL0lPnAmfsh2V6JMRWpyRgNCT +MjqBzrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkAAi-00HIjn-9f; Mon, 08 Nov 2021 19:19:12 +0000 Received: from out03.mta.xmission.com ([166.70.13.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkAAe-00HIin-5h for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 19:19:09 +0000 Received: from in02.mta.xmission.com ([166.70.13.52]:43664) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mkAAb-00E1Hk-GA; Mon, 08 Nov 2021 12:19:05 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:59808 helo=email.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mkAAZ-002ABU-G3; Mon, 08 Nov 2021 12:19:04 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Nathan Chancellor Cc: Santosh Shilimkar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann References: <20211102160315.1067553-1-nathan@kernel.org> Date: Mon, 08 Nov 2021 13:18:41 -0600 In-Reply-To: <20211102160315.1067553-1-nathan@kernel.org> (Nathan Chancellor's message of "Tue, 2 Nov 2021 09:03:15 -0700") Message-ID: <877ddipib2.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-XM-SPF: eid=1mkAAZ-002ABU-G3; ; ; mid=<877ddipib2.fsf@disp2133>; ; ; hst=in02.mta.xmission.com; ; ; ip=68.227.160.95; ; ; frm=ebiederm@xmission.com; ; ; spf=neutral X-XM-AID: U2FsdGVkX1+r9bFhQzEzvlEH5/zaHOV1889fUy/lLVc= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread() X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_111908_234531_517F4C09 X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Nathan Chancellor writes: > This function should not return a value: > > drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread': > drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type] > 429 | return 0; > | ^ > drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here > 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors Apologies for not replying to this sooner. I did not realize at first that this was in response to one of my changes. Arnd also reported this and included a correct fix please see: https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org Thank you, Eric > > Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit") > Signed-off-by: Nathan Chancellor > --- > drivers/soc/ti/wkup_m3_ipc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 0733443a2631..2238beb40f8d 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > dev_err(dev, "rproc_boot failed\n"); > else > m3_ipc_state = m3_ipc; > - > - return 0; > } > > static int wkup_m3_ipc_probe(struct platform_device *pdev) > > base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel