From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87F9C43381 for ; Tue, 5 Mar 2019 18:12:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB2E920652 for ; Tue, 5 Mar 2019 18:12:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZsZgUXde" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB2E920652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5WFqMao7J1DnrOV9t/zUW7VhVRLX8n1d+c74lACs5gs=; b=ZsZgUXdeV7pV5jjfvVrIlkkFV 1ZTwJsNwcfo6TpBa1rmJHp8+iwHRiMjNJAoK7X6thwFn027E+kiFpP6ey0DV7a0rBK4QCOCBN9dOg rWwO7hTWXpVcF3o7L7+6shKwGRhQXZ3pRygb/Qapay79OUZJxFe2bwISMQeWsgd0cOhjAywGIioOe NSe5X50V0Q3Xd5HXOFQmltNqpwK+ze8u3vLdsRsG/pTZfYEiCugw0sAnVmOVo37WIFhNX3yuVjsw5 qW3BO48TXZkpN2J/uDj2OAzMsaSau/H2tchqXD3yvmKLI7ciNvF2pq0tSvivTfxGZt2HZcvEq8GuB ydbN9SNwA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1EXr-0002vR-4h; Tue, 05 Mar 2019 18:12:03 +0000 Received: from anholt.net ([50.246.234.109]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1EXo-0002v6-4l for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 18:12:01 +0000 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 5EB3A10A2B02; Tue, 5 Mar 2019 10:11:56 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gUpfrMm9nWVS; Tue, 5 Mar 2019 10:11:54 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id D975C10A2A9B; Tue, 5 Mar 2019 10:11:54 -0800 (PST) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 72D5D2FE464E; Tue, 5 Mar 2019 10:11:54 -0800 (PST) From: Eric Anholt To: Maxime Ripard , Alex Deucher Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data In-Reply-To: <20190305091240.sbkvdwosocaytx22@flea> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> <87wole76ws.fsf@anholt.net> <20190305091240.sbkvdwosocaytx22@flea> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Tue, 05 Mar 2019 10:11:51 -0800 Message-ID: <877eddtcm0.fsf@anholt.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_101200_221975_CF944579 X-CRM114-Status: GOOD ( 22.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , Maarten Lankhorst , Maling list - DRI developers , Paul Kocialkowski , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============2664701126194832473==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2664701126194832473== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxime Ripard writes: > [ Unknown signature status ] > On Mon, Mar 04, 2019 at 03:05:31PM -0500, Alex Deucher wrote: >> On Mon, Mar 4, 2019 at 2:53 PM Eric Anholt wrote: >> > >> > Maxime Ripard writes: >> > >> > > In some cases, in order to accomodate with displays with poor EDIDs,= we >> > > need to ignore that the monitor alledgedly supports audio output and >> > > disable the audio output. >> > > >> > > Signed-off-by: Maxime Ripard >> > > --- >> > > drivers/gpu/drm/drm_edid.c | 8 ++++++++ >> > > 1 file changed, 8 insertions(+) >> > > >> > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> > > index 990b1909f9d7..c0258b011bb2 100644 >> > > --- a/drivers/gpu/drm/drm_edid.c >> > > +++ b/drivers/gpu/drm/drm_edid.c >> > > @@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *edi= d) >> > > } >> > > EXPORT_SYMBOL(drm_detect_hdmi_monitor); >> > > >> > > +static bool ignore_edid_audio =3D false; >> > > +module_param(ignore_edid_audio, bool, 0644); >> > > +MODULE_PARM_DESC(ignore_edid_audio, >> > > + "Ignore the EDID and always consider that a monitor d= oesn't have audio capabilities"); >> > > + >> > > /** >> > > * drm_detect_monitor_audio - check monitor audio capability >> > > * @edid: EDID block to scan >> > > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edi= d) >> > > bool has_audio =3D false; >> > > int start_offset, end_offset; >> > > >> > > + if (ignore_edid_audio) >> > > + goto end; >> > > + >> > > edid_ext =3D drm_find_cea_extension(edid); >> > > if (!edid_ext) >> > > goto end; >> > >> > It looks like the motivation for the original flag on Raspberry Pi was >> > "I've got a non-audio monitor, but the system comes up trying to play >> > audio to HDMI instead of the analog jack". Do we have some way for DRM >> > to communicate to ALSA that this is not the right place to try to play >> > audio by default? >>=20 >> Apparently not. We have users using debug knobs in our drivers to >> disable display audio because ALSA defaults to that rather than other >> audio. > > I guess one way to do this would be to register the card only when an > audio-capable monitor is connected instead of doing this at probe > time. I'm not sure how convenient it is for userspace though. Yeah, I have no idea how this is supposed to work, but pulseaudio keeps doing reasonable things on my intel desktop so I'm wondering if we're just missing some bit of the HDMI driver communicating to ALSA about the state of the audio sink. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx+u+cACgkQtdYpNtH8 nuitMhAArCLoCGlOAh+easnD06nxsgndiFq38iHjvlKDh4WBH4Pr3JTe2Sn1e5i3 zEdwfoPkGXytFa6hLHGW+mAMK92snBhzYZY7oOz6z/8pGClSNb64/FV6pSotxUMC ks2+tKdZfVQz1xzByK8T/P/rwoB487T2+wMFICKpGjLEDECW//DMX7rwxnQaVJRs ZYQDHzl299qx8hRW/JJrjur+TEijOdLuOEndsdHVbsIdbiOnEx56sV63qJAGl3W5 0/eDx18uydfghYa60h7dLnQo8zxwQ/LpswFGxxEGmQb98Yr2llc88Iz8nr7ST1Et i7wJtoZxMAEWx3ZVGF26UulMeIoHUSZEGb4VXeK+olg3LERJoFd2Id83r9pYeiUv xkoOFM23u0YaLiGkXvmqayxgX6h3F7rdvgkYQSimOGa5qpg91CZqZjh1zlgXlryF fEVou2KE/YzTHJaPWqTybLpkLMGHJLttiHwht0Czrc316JzzcuQUzC8FYkYFrwDA lVoraNgKNyIHjfX05rM+1Q7f85h6u1d3eDd+Yp01xnRwpBFl1oZUZrKsl16u5FQg V+u5sY3dA9nHFieCoqBeYT+/V6wWdvoVzD/ygBKD7Q6kJIKvUWLLaIH2xD1CfkvP vX59pjh6QgmUosZcEaGODtVoDHwW6AoqLhCI3BsqTf/vnGq9cGM= =Z3NN -----END PGP SIGNATURE----- --=-=-=-- --===============2664701126194832473== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2664701126194832473==--