linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: neil@brown.name (NeilBrown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] staging: mt7621-pci: Fix coding style issues
Date: Mon, 04 Jun 2018 10:13:58 +1000	[thread overview]
Message-ID: <877enfqugp.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <cover.1528040188.git.abdun.nihaal@gmail.com>

On Sun, Jun 03 2018, Abdun Nihaal wrote:

> This patchset fixes the following set of coding style 
> issues found using checkpatch.
>
> ERROR: space prohibited after that open parenthesis '('
> ERROR: trailing whitespace
> ERROR: space required before the open parenthesis '('
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: spaces required around that '=' (ctx:VxW)
> ERROR: spaces required around that '==' (ctx:WxV)
> ERROR: that open brace { should be on the previous line

Hi,
 thanks for contributing these, how ever some of these issues have
 already been address (not all).  I think you must be working from an
 old try.
 When submitting patches to drives/staging, they should be based on
 the staging-next branch of
    git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

 Also, I'd suggest leaving linux-arm-kernel and linux-mediatek off the
 cc list.  They are unlikely to be interested until the driver is ready
 to be moved out of drivers/staging.

Thanks,
NeilBrown


>
> Abdun Nihaal (7):
>   staging: mt7621-pci: Remove space after open parenthesis
>   staging: mt7621-pci: remove trailing whitespace
>   staging: mt7621-pci: add space before open parenthesis
>   staging: mt7621-pci: add space after comma symbol
>   staging: mt7621-pci: add spaces around equal symbol
>   staging: mt7621-pci: add space after '==' symbol
>   staging: mt7621-pci: fix coding style error
>
>  drivers/staging/mt7621-pci/pci-mt7621.c | 114 ++++++++++++------------
>  1 file changed, 56 insertions(+), 58 deletions(-)
>
> -- 
> 2.17.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180604/e81a42a0/attachment.sig>

      parent reply	other threads:[~2018-06-04  0:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-03 15:59 [PATCH 0/7] staging: mt7621-pci: Fix coding style issues Abdun Nihaal
2018-06-03 15:59 ` [PATCH 1/7] staging: mt7621-pci: Remove space after open parenthesis Abdun Nihaal
2018-06-03 15:59 ` [PATCH 2/7] staging: mt7621-pci: remove trailing whitespace Abdun Nihaal
2018-06-03 16:00 ` [PATCH 3/7] staging: mt7621-pci: add space before open parenthesis Abdun Nihaal
2018-06-03 16:00 ` [PATCH 4/7] staging: mt7621-pci: add space after comma symbol Abdun Nihaal
2018-06-03 16:00 ` [PATCH 5/7] staging: mt7621-pci: add spaces around equal symbol Abdun Nihaal
2018-06-03 16:00 ` [PATCH 6/7] staging: mt7621-pci: add space after '==' symbol Abdun Nihaal
2018-06-03 16:00 ` [PATCH 7/7] staging: mt7621-pci: fix coding style error Abdun Nihaal
2018-06-04  0:13 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877enfqugp.fsf@notabene.neil.brown.name \
    --to=neil@brown.name \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).