linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: remove devicetree boards from pxa_defconfig
Date: Sun, 10 Jul 2016 09:50:40 +0200	[thread overview]
Message-ID: <877fcu3p9r.fsf@belgarion.home> (raw)
In-Reply-To: <1464985766-20754-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Fri, 3 Jun 2016 22:29:26 +0200")

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> If both legacy and device-tree machines are mixed in the same defconfig,
> the legacy boards don't boot up anymore with gpio request deferral
> errors.
>
> This is seen when attempting to run akita, borzoi, spitz, terrier, or
> tosa in qemu with pxa_defconfig.
>
> The real reason behind is that gpio handling for pxa in its current
> state cannot be built for _both_ a devicetree machine (ie. pxa-dt.c) and
> a non devicetree machine (ie. corgi, tosa, ...).
>
> This is turn is because for devicetree a pinctrl is enforced for the
> machine, and a pinctrl driver is required. If it's not available,
> pxa_gpio_request() fails on pinctrl_request_gpio() and returns
> -EPROBE_DEFER.  It was introduced by commit f806dac5938b
> ("ARM: pxa: activate pinctrl for device-tree machines").
>
> Now the true chicken and egg problem is than machine files,
> ie. arch/arm/mach-pxa/xxx.c are using gpio before the drivers are
> probed, in the init_machine() function, and that's why pinctrl/gpio for
> legacy machine files is a bit difficult.
>
> As for now, to keep the compilation coverage and testing of legacy
> machines, this patch removes the 2 devicetree machines from
> pxa_defconfig.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Applied to pxa/for-next, with a huge delay.

Cheers.

--
Robert

      reply	other threads:[~2016-07-10  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 20:29 [PATCH] ARM: pxa: remove devicetree boards from pxa_defconfig Robert Jarzmik
2016-07-10  7:50 ` Robert Jarzmik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fcu3p9r.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).