linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: OMAP4: VC: fix I2C timing
Date: Tue, 29 May 2012 14:30:34 -0700	[thread overview]
Message-ID: <877gvuekud.fsf@ti.com> (raw)
In-Reply-To: <1336139842-845-2-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Fri, 4 May 2012 16:57:20 +0300")

Tero Kristo <t-kristo@ti.com> writes:

> Current I2C timing parameters do not work with Panda board at least.
> Parameters updated based on TI recommendation.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>

Let's fix this correctly by deriving/calculating them from the proper
source clocks.

Otherwise, this is going to work for Panda and break for something else.

Kevin

> ---
>  arch/arm/mach-omap2/vc.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index 1fd976e..a731400 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -585,7 +585,9 @@ static void __init omap4_vc_init_channel(struct voltagedomain *voltdm)
>  	omap4_set_timings(voltdm, true);
>  
>  	/* XXX These are magic numbers and do not belong! */
> -	vc_val = (0x60 << OMAP4430_SCLL_SHIFT | 0x26 << OMAP4430_SCLH_SHIFT);
> +	vc_val = (0x28 << OMAP4430_SCLL_SHIFT | 0x2c << OMAP4430_SCLH_SHIFT);
> +	vc_val |= (0x0b << OMAP4430_HSSCLL_SHIFT);
> +	vc_val |= (0x0 << OMAP4430_HSSCLH_SHIFT);
>  	voltdm->write(vc_val, OMAP4_PRM_VC_CFG_I2C_CLK_OFFSET);
>  }

  reply	other threads:[~2012-05-29 21:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04 13:57 [PATCH 0/3] ARM: OMAP4: add support for TPS62361 PMIC Tero Kristo
2012-05-04 13:57 ` [PATCH 1/3] ARM: OMAP4: VC: fix I2C timing Tero Kristo
2012-05-29 21:30   ` Kevin Hilman [this message]
2012-05-30  8:50     ` Tero Kristo
2012-05-04 13:57 ` [PATCH 2/3] ARM: OMAP3+: PM: introduce a central pmic control Tero Kristo
2012-05-07 12:00   ` Vishwanath Sripathy
2012-05-07 13:24     ` Tero Kristo
2012-05-04 13:57 ` [PATCH 3/3] ARM: OMAP2+ PM: Add support for TPS62361 Tero Kristo
2012-05-04 22:00   ` Nishanth Menon
2012-05-07  7:38     ` Tero Kristo
2012-05-07 14:32       ` Menon, Nishanth
2012-05-29 21:29 ` [PATCH 0/3] ARM: OMAP4: add support for TPS62361 PMIC Kevin Hilman
2012-05-30  8:12   ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gvuekud.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).