* [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
@ 2011-11-03 7:00 Axel Lin
2011-11-03 14:26 ` Kevin Hilman
2011-11-07 20:35 ` Tony Lindgren
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2011-11-03 7:00 UTC (permalink / raw)
To: linux-arm-kernel
Include linux/export.h to fix below build warning:
CC arch/arm/plat-omap/omap_device.o
arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This resend also CC linux-omap at vger.kernel.org and linux-arm-kernel at lists.infradead.org.
This patch is against linux-next 20111103.
arch/arm/plat-omap/omap_device.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
index cd90bed..f839f94 100644
--- a/arch/arm/plat-omap/omap_device.c
+++ b/arch/arm/plat-omap/omap_device.c
@@ -78,6 +78,7 @@
#undef DEBUG
#include <linux/kernel.h>
+#include <linux/export.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/err.h>
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
2011-11-03 7:00 [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h Axel Lin
@ 2011-11-03 14:26 ` Kevin Hilman
2011-11-03 14:47 ` Paul Gortmaker
2011-11-07 20:35 ` Tony Lindgren
1 sibling, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2011-11-03 14:26 UTC (permalink / raw)
To: linux-arm-kernel
Axel Lin <axel.lin@gmail.com> writes:
> Include linux/export.h to fix below build warning:
>
> CC arch/arm/plat-omap/omap_device.o
> arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
> arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Thanks, will queue as a fix for v3.2-rc
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
2011-11-03 14:26 ` Kevin Hilman
@ 2011-11-03 14:47 ` Paul Gortmaker
2011-11-03 17:48 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2011-11-03 14:47 UTC (permalink / raw)
To: linux-arm-kernel
On 11-11-03 10:26 AM, Kevin Hilman wrote:
> Axel Lin <axel.lin@gmail.com> writes:
>
>> Include linux/export.h to fix below build warning:
>>
>> CC arch/arm/plat-omap/omap_device.o
>> arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
>> arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
>> arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Thanks, will queue as a fix for v3.2-rc
It is probably better if I track this, since export.h won't
exist until Linus pulls the module.h-split tree, and I'm
guessing that will be closer to the end of the merge window.
Thanks,
Paul.
>
> Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
2011-11-03 14:47 ` Paul Gortmaker
@ 2011-11-03 17:48 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2011-11-03 17:48 UTC (permalink / raw)
To: linux-arm-kernel
Paul Gortmaker <paul.gortmaker@windriver.com> writes:
> On 11-11-03 10:26 AM, Kevin Hilman wrote:
>> Axel Lin <axel.lin@gmail.com> writes:
>>
>>> Include linux/export.h to fix below build warning:
>>>
>>> CC arch/arm/plat-omap/omap_device.o
>>> arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
>>> arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
>>> arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>>
>> Thanks, will queue as a fix for v3.2-rc
>
> It is probably better if I track this, since export.h won't
> exist until Linus pulls the module.h-split tree, and I'm
> guessing that will be closer to the end of the merge window.
OK, sounds good. Feel free to add:
Acked-by: Kevin Hilman <khilman@ti.com>
Thanks,
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
2011-11-03 7:00 [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h Axel Lin
2011-11-03 14:26 ` Kevin Hilman
@ 2011-11-07 20:35 ` Tony Lindgren
1 sibling, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2011-11-07 20:35 UTC (permalink / raw)
To: linux-arm-kernel
* Axel Lin <axel.lin@gmail.com> [111102 23:26]:
> Include linux/export.h to fix below build warning:
>
> CC arch/arm/plat-omap/omap_device.o
> arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
> arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
Applying into fixes thanks.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-07 20:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-03 7:00 [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h Axel Lin
2011-11-03 14:26 ` Kevin Hilman
2011-11-03 14:47 ` Paul Gortmaker
2011-11-03 17:48 ` Kevin Hilman
2011-11-07 20:35 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).