From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91sam9g45: fix i2c bus speed
Date: Thu, 23 Sep 2010 12:54:30 +0200 [thread overview]
Message-ID: <877hicafx5.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20100923103645.GA23295@n2100.arm.linux.org.uk> (Russell King's message of "Thu, 23 Sep 2010 11:36:45 +0100")
>>>>> "Russell" == Russell King <- ARM Linux <linux@arm.linux.org.uk>> writes:
Hi,
Russell> Jean is right - if you want to care this much about getting the I2C
Russell> transfer rate as close to 100kHz or 400kHz (without exceeding it),
Russell> you need to pass the required speed and run some sort of calibration
Russell> in the driver to calculate the correct delay.
I don't care about all those things. I just want to fix the obvious bug
that happened while copying this code from the older (slower) SoCs
without taking into consideration the faster gpio handling - E.G.
- .udelay = 2, /* ~100 kHz */
+ .udelay = 5, /* ~100 kHz */
So the comment matches and devices that don't handle >100KHz works on
the new SoCs as well.
And yes, if you run the SoC at nonstandard (slower) speed this might be
slower than 100Khz, but that's still safe, so not a big deal.
And then if Jean wants to extend the interface to make the speed
configurable from the board code, he can do so independently of this
patch.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-09-23 10:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 9:31 [PATCH] at91sam9g45: fix i2c bus speed Peter Korsgaard
2010-09-22 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 11:08 ` Peter Korsgaard
2010-09-22 14:34 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 14:54 ` Wolfgang Wegner
2010-09-22 16:09 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 15:18 ` Peter Korsgaard
2010-09-22 16:05 ` Nicolas Ferre
2010-09-22 16:10 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 16:06 ` Nicolas Ferre
2010-09-23 8:18 ` Nicolas Ferre
2010-09-23 9:22 ` Peter Korsgaard
2010-09-23 9:31 ` Russell King - ARM Linux
2010-09-23 10:09 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 10:24 ` Peter Korsgaard
2010-09-23 10:21 ` Peter Korsgaard
2010-09-23 10:36 ` Russell King - ARM Linux
2010-09-23 10:54 ` Peter Korsgaard [this message]
2010-09-23 11:16 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 11:32 ` Peter Korsgaard
2010-09-23 12:00 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 11:07 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hicafx5.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).