From: Quan Nguyen <quan@os.amperecomputing.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
openbmc@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>, thang@os.amperecomputing.com
Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC
Date: Thu, 21 Jul 2022 09:46:10 +0700 [thread overview]
Message-ID: <878f9889-0255-96d8-77c8-19b0542932f4@os.amperecomputing.com> (raw)
In-Reply-To: <ab78f85c-dd0a-9176-103f-8e4abe01b8f9@linaro.org>
On 20/07/2022 17:36, Krzysztof Kozlowski wrote:
> On 20/07/2022 10:52, Quan Nguyen wrote:
>> The Mt. Mitchell BMC is an ASPEED AST2600-based BMC for the Mt. Mitchell
>> hardware reference platform with AmpereOne(TM) processor.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> Signed-off-by: Phong Vo <phong@os.amperecomputing.com>
>> Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
>> ---
>> v2 :
>> + Remove bootargs [Krzysztof]
>> + Fix gpio-keys nodes name to conform with device tree binding
>> documents [Krzysztof]
>> + Fix some nodes to use generic name [Krzysztof]
>> + Remove unnecessary blank line [Krzysztof]
>> + Fix typo "LTC" to "LLC" in license info and corrected license
>> info to GPL-2.0-only
>>
>> arch/arm/boot/dts/Makefile | 1 +
>> .../boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 577 ++++++++++++++++++
>> 2 files changed, 578 insertions(+)
>> create mode 100644 arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>>
>
> (...)
>
>> +
>> +&i2c3 {
>> + status = "okay";
>> +};
>> +
>> +&i2c4 {
>> + status = "okay";
>> +
>> + adc_i2c: adc-i2c@16 {
>
> Node name: just "adc"
>
Thanks, will fix.
>> + compatible = "lltc,ltc2497";
>> + reg = <0x16>;
>> + vref-supply = <&voltage_mon_reg>;
>> + #io-channel-cells = <1>;
>> + status = "okay";
>
> Isn't this new node? Why do you need status here?
>
Thanks for the comment. The drivers/iio/adc/ltc2497.c does not check for
the status indeed. Will remove it.
>> + };
>> +
>> + eeprom@50 {
>> + compatible = "atmel,24c64";
>> + reg = <0x50>;
>> + pagesize = <32>;
>> + };
>> +
>
> (...)
>
>> +
>> +&gpio1 {
>> + gpio-line-names =
>> + /*18A0-18A7*/ "","","","","","","","",
>> + /*18B0-18B7*/ "","","","","emmc-rst-n","","s0-soc-pgood","",
>> + /*18C0-18C7*/ "uart1-mode0","uart1-mode1","uart2-mode0","uart2-mode1",
>> + "uart3-mode0","uart3-mode1","uart4-mode0","uart4-mode1",
>> + /*18D0-18D7*/ "","","","","","","","",
>> + /*18E0-18E3*/ "","","","";
>> +};
>> +
>
> You have a trailing line error.
>
>
Thanks, will fix
- Quan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-21 2:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 8:52 [PATCH v2 0/2] Add device tree for Ampere's Mt. Mitchell BMC Quan Nguyen
2022-07-20 8:52 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: document Ampere Mt.Mitchell BMC compatibles Quan Nguyen
2022-07-20 10:34 ` Krzysztof Kozlowski
2022-07-21 2:46 ` Quan Nguyen
2022-07-21 7:11 ` Krzysztof Kozlowski
2022-07-20 8:52 ` [PATCH v2 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC Quan Nguyen
2022-07-20 10:36 ` Krzysztof Kozlowski
2022-07-21 2:46 ` Quan Nguyen [this message]
2022-07-21 2:02 ` Andrew Jeffery
2022-08-15 6:20 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878f9889-0255-96d8-77c8-19b0542932f4@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).