From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Hui-Ping Chen <hpchen0nvt@gmail.com>
Cc: richard@nod.at, vigneshr@ti.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
nikita.shubin@maquefel.me, arnd@arndb.de, vkoul@kernel.org,
esben@geanix.com, linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 0/2] Add support for nuvoton ma35 nand controller
Date: Thu, 05 Dec 2024 11:26:30 +0100 [thread overview]
Message-ID: <878qsuwhm1.fsf@bootlin.com> (raw)
In-Reply-To: <20241204025129.150525-1-hpchen0nvt@gmail.com> (Hui-Ping Chen's message of "Wed, 4 Dec 2024 02:51:27 +0000")
Hi,
On 04/12/2024 at 02:51:27 GMT, Hui-Ping Chen <hpchen0nvt@gmail.com> wrote:
> This patch series adds the mtd nand driver for the nuvoton ma35 ARMv8 SoC.
> It includes DT binding documentation and the ma35 mtd nand driver.
>
> v10:
> - Update ma35d1 mtd nand driver
> - Add unsupported write page handling.
I was about to apply it but...
[31m●[0m checkpatch.pl: 117: WARNING: please write a help paragraph that fully describes the config symbol
[31m●[0m checkpatch.pl: 141: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
[31m●[0m checkpatch.pl: 348: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 352: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 352: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 429: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 465: CHECK: spaces preferred around that '*' (ctx:VxV)
[31m●[0m checkpatch.pl: 465: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 466: CHECK: spaces preferred around that '*' (ctx:VxV)
[31m●[0m checkpatch.pl: 466: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 467: CHECK: spaces preferred around that '*' (ctx:VxV)
[31m●[0m checkpatch.pl: 467: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 468: CHECK: spaces preferred around that '*' (ctx:VxV)
[31m●[0m checkpatch.pl: 468: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 479: CHECK: spaces preferred around that '*' (ctx:VxV)
[31m●[0m checkpatch.pl: 479: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 481: CHECK: spaces preferred around that '*' (ctx:VxV)
[31m●[0m checkpatch.pl: 481: CHECK: spaces preferred around that '+' (ctx:VxV)
[31m●[0m checkpatch.pl: 514: CHECK: Unbalanced braces around else statement
[31m●[0m checkpatch.pl: 611: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 650: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 665: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 675: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 689: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 699: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 715: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 756: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 805: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 935: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 950: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 953: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 975: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 1001: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 1018: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 1131: CHECK: Alignment should match open parenthesis
[31m●[0m checkpatch.pl: 1159: WARNING: DT compatible string "nuvoton,ma35d1-nand" appears un-documented -- check ./Documentation/devicetree/bindings/
Please fix these warnings and checks.
You might want to use --strict by default.
Thanks,
Miquèl
next prev parent reply other threads:[~2024-12-05 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 2:51 [PATCH v10 0/2] Add support for nuvoton ma35 nand controller Hui-Ping Chen
2024-12-04 2:51 ` [PATCH v10 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings Hui-Ping Chen
2024-12-04 2:51 ` [PATCH v10 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC Hui-Ping Chen
2024-12-05 10:26 ` Miquel Raynal [this message]
2024-12-06 1:43 ` [PATCH v10 0/2] Add support for nuvoton ma35 nand controller Hui-Ping Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qsuwhm1.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=esben@geanix.com \
--cc=hpchen0nvt@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nikita.shubin@maquefel.me \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).