From: Michael Ellerman <mpe@ellerman.id.au>
To: "Dr. David Alan Gilbert" <linux@treblig.org>,
Sean Anderson <sean.anderson@linux.dev>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'
Date: Mon, 22 Jul 2024 17:24:16 +1000 [thread overview]
Message-ID: <878qxtx527.fsf@mail.lhotse> (raw)
In-Reply-To: <Zp2QtPET9649y9pA@gallifrey>
"Dr. David Alan Gilbert" <linux@treblig.org> writes:
> * Sean Anderson (sean.anderson@linux.dev) wrote:
>> On 5/28/24 19:11, linux@treblig.org wrote:
>> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
>> >
>> > 'cgr_comp' has been unused since
>> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in
>> > qman_delete_cgr_safe()").
>> >
>> > Remove it.
>> >
>> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>> > ---
>> > drivers/soc/fsl/qbman/qman.c | 5 -----
>> > 1 file changed, 5 deletions(-)
>> >
>> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
>> > index 7e9074519ad2..4dc8aba33d9b 100644
>> > --- a/drivers/soc/fsl/qbman/qman.c
>> > +++ b/drivers/soc/fsl/qbman/qman.c
>> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>> > }
>> > EXPORT_SYMBOL(qman_delete_cgr);
>> >
>> > -struct cgr_comp {
>> > - struct qman_cgr *cgr;
>> > - struct completion completion;
>> > -};
>> > -
>> > static void qman_delete_cgr_smp_call(void *p)
>> > {
>> > qman_delete_cgr((struct qman_cgr *)p);
>>
>> Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
>
> Hi Sean,
> Do you know who will pick this one up?
> I got a notification a while ago from a patchwork at
> linuxppc-dev marked 'Handled elsewhere' - but I'm not
> sure where.
drivers/soc/fsl was orphaned, but Christophe has recently volunteered to
look after it.
This patch looks trivial so I can just pick it up if you like Christophe?
cheers
next prev parent reply other threads:[~2024-07-22 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 23:11 [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp' linux
2024-05-30 14:59 ` Sean Anderson
2024-07-21 22:50 ` Dr. David Alan Gilbert
2024-07-22 7:24 ` Michael Ellerman [this message]
2024-07-22 17:14 ` Christophe Leroy
2024-08-12 11:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qxtx527.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=camelia.groza@nxp.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).