From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E40FC3DA59 for ; Mon, 22 Jul 2024 07:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7xYb9iaHHsO53zX4r++CVPw1TcU/Qoda/IxZitAYyes=; b=2a3iEbaEJ7+73ocsERSHjsj+Qb MdIkG47YOkFuwlR3fWHZEkupdsxNt1qbGN64mXmUoIm6YnKxuh/5cQC2brVaDIQ5xsptB9f1t854D 6XipVPRLENJB0N8aZv82f+48AI+FYlBKIpFhP4GP93zY1I2kX/ro8PZcLIzyvtCd5H+BGn76wjOGB 7Mt2V53KOwDky7oVzWfQsPW6JtOjtoSvPbodbY8FP8bqG8+oJVQml32j6WT9Wz+gEYRQi2KIMCVFw M+BYauZvUFnA/MCAerUdXhCyDLQk8veJugiBDTEIJux5RKJRtLPUA/oSH6a6Fyd3+x5kEI4TsvCSz YB7z5zbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVnQg-00000008hLM-33js; Mon, 22 Jul 2024 07:25:54 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76] helo=mail.ozlabs.org) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVnPF-00000008h8s-02pW for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 07:25:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1721633057; bh=7xYb9iaHHsO53zX4r++CVPw1TcU/Qoda/IxZitAYyes=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Mo57lr+Rk5tEBPzo+Uh0Sak5AZzOKKbaJhj9ORzW0/FazE6xM0EWBA2oJR49LeSCh q+r0cxX76MlKwT+R0sEsg+fSVS4B3k9G/U7iDTYZGq27GwkQuJ7q7NybR1DBxMA04w ugGEn4j6oEy4xK5CUYjRuNJeIgrUhEA8z0KBD+QqwXdUVa0tHBYi3NY+FolJoA0HZu gGX3FMtWx9flPJtO5aWg7dnqSh+daKFEVD3N/agHqfzGn4v5qhreUFUn3K+MdBZ/Vm Pk0LtjQ+oJtEH5EeRmtZLBU1W9/i5ClHMzEsdYxxdoN7Kme1c+fFa21WrPKfC4TsbH anjTTO/JXdlOw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4WSBc13ZZ6z4wc1; Mon, 22 Jul 2024 17:24:17 +1000 (AEST) From: Michael Ellerman To: "Dr. David Alan Gilbert" , Sean Anderson , Christophe Leroy Cc: camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp' In-Reply-To: References: <20240528231123.136664-1-linux@treblig.org> <336239e6-4369-44ea-a60c-d300cf6e6f81@linux.dev> Date: Mon, 22 Jul 2024 17:24:16 +1000 Message-ID: <878qxtx527.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_002425_232375_CF3D18F6 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "Dr. David Alan Gilbert" writes: > * Sean Anderson (sean.anderson@linux.dev) wrote: >> On 5/28/24 19:11, linux@treblig.org wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > 'cgr_comp' has been unused since >> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in >> > qman_delete_cgr_safe()"). >> > >> > Remove it. >> > >> > Signed-off-by: Dr. David Alan Gilbert >> > --- >> > drivers/soc/fsl/qbman/qman.c | 5 ----- >> > 1 file changed, 5 deletions(-) >> > >> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c >> > index 7e9074519ad2..4dc8aba33d9b 100644 >> > --- a/drivers/soc/fsl/qbman/qman.c >> > +++ b/drivers/soc/fsl/qbman/qman.c >> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr) >> > } >> > EXPORT_SYMBOL(qman_delete_cgr); >> > >> > -struct cgr_comp { >> > - struct qman_cgr *cgr; >> > - struct completion completion; >> > -}; >> > - >> > static void qman_delete_cgr_smp_call(void *p) >> > { >> > qman_delete_cgr((struct qman_cgr *)p); >> >> Reviewed-by: Sean Anderson > > Hi Sean, > Do you know who will pick this one up? > I got a notification a while ago from a patchwork at > linuxppc-dev marked 'Handled elsewhere' - but I'm not > sure where. drivers/soc/fsl was orphaned, but Christophe has recently volunteered to look after it. This patch looks trivial so I can just pick it up if you like Christophe? cheers