From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 501E2C3DA59 for ; Mon, 15 Jul 2024 12:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w7M2Rn4yOG14r0SVZwSDAaIZrhriAzRAFxM94c8UQpQ=; b=ev5wPQ70UTODjayv98FHvDLahk Cvvi3wE65a58f9DYML/N4L8j4fstiEslGcmvjcg25IhdWfQIP20rFBGVVPOppzNfCxHhRq+TRjAdD nM7O9om7vXBb4ItieN+Yvm1XrRlE0KifOjnBZQhVJHtc1LCUvVnvODKnJIyP+LvWWv8Jg/+4YQK4D qw/WtPtoxS0lJY6qPXsT7t4skIWdkDUc5A5ArxhbDT4uF7In0iHl4ftCUNu8NtDrE1Nn8mcI2hcna Wmg7NqrrHCCvPIxuV5R0GS5VtqMltdC6sNHGnaOP3M3ZCmeaca/RgnOdm7XMQr8Bgf+MaHUk+1R/F qKM+bAKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTLIJ-000000077yI-1RBo; Mon, 15 Jul 2024 12:59:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTLHy-000000077pA-1ce3 for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 12:58:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7CC7C60FDA; Mon, 15 Jul 2024 12:58:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EEE6C32782; Mon, 15 Jul 2024 12:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721048325; bh=938N090mX21Ue6dt/U1tChZbGlOk3IFslj5zQ0oos3I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kJ0uShy+5FUGoMfUDinFemfd8tFcTtSn+1daGiXEJyXYP7Rwq/7pgJlOAZHxf2luj VGE0rvqj85rwDKtLX8bSMddybJiPcKCYX8zBxzcxA6oR56P6uEQRjWCMrVjpkhTPqq NbP/4sfoRcCG3Tb3SBuWuMRu1QQBgMhu2gyBlGst/r5DASbLkr/eXXJv1AdgKYcsA2 DnvnNQZAqZM+9JDyKENoNnmlgPhInGTCPX2de6LdPkbrM6DTQD80JK52V/jFTVdxnE MfqBQqh6Lp1OWGj6xt/hiXyu/t3L8yCb2EqE4q7czpv2gWWQei5ZN2OhASQZDNcr6z t9m9zbS+sLJiA== Received: from [185.201.63.251] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sTLHu-00CVgq-CV; Mon, 15 Jul 2024 13:58:42 +0100 Date: Mon, 15 Jul 2024 13:58:13 +0100 Message-ID: <878qy26cd6.wl-maz@kernel.org> From: Marc Zyngier To: Johan Hovold Cc: Thomas Gleixner , LKML , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de Subject: Re: [patch V4 00/21] genirq, irqchip: Convert ARM MSI handling to per device MSI domains In-Reply-To: References: <20240623142137.448898081@linutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.201.63.251 X-SA-Exim-Rcpt-To: johan@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_055846_573204_F4568FFE X-CRM114-Status: GOOD ( 29.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 15 Jul 2024 12:18:47 +0100, Johan Hovold wrote: > > On Sun, Jun 23, 2024 at 05:18:31PM +0200, Thomas Gleixner wrote: > > This is version 4 of the series to convert ARM MSI handling over to > > per device MSI domains. > > > The conversion aims to replace the existing platform MSI mechanism and > > enables ARM to support the future PCI/IMS mechanism. > > > The series is only lightly tested due to lack of hardware, so we rely on > > the people who have access to affected machines to help with testing. > > > > If there are no major objections raised or testing fallout reported, I'm > > aiming this series for the next merge window. > > This series only showed up in linux-next last Friday and broke interrupt > handling on Qualcomm platforms like sc8280xp (e.g. Lenovo ThinkPad X13s) > and x1e80100 that use the GIC ITS for PCIe MSIs. > > I've applied the series (21 commits from linux-next) on top of 6.10 and > can confirm that the breakage is caused by commits: > > 3d1c927c08fc ("irqchip/gic-v3-its: Switch platform MSI to MSI parent") > 233db05bc37f ("irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X]") > > Applying the series up until the change before 3d1c927c08fc unbreaks the > wifi on one machine: > > ath11k_pci 0006:01:00.0: failed to enable msi: -22 > ath11k_pci 0006:01:00.0: probe with driver ath11k_pci failed with error -22 > > and backing up until the commit before 233db05bc37f makes the NVMe come > up again during boot on another. > > I have not tried to debug this further. I need a few things from you though, because you're not giving much to help you (and I'm travelling, which doesn't help). Can you at least investigate what in ath11k_pci_alloc_msi() causes the wifi driver to be upset? Does it normally use a single MSI vector or MSI-X? How about your nVME device? It would also help if you could define the DEBUG symbol at the very top of irq-gic-v3-its.c and report the debug information that the ITS driver dumps. Thanks, M. -- Without deviation from the norm, progress is not possible.