From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84F50C2BA15 for ; Tue, 18 Jun 2024 09:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=O10CY0NYWOK/A1FQFwDoQ6/CV5g+Fb6h88aPeKvy6As=; b=WcTHcDBg0Jz9AKL5zvkOTgSwOK Dw/UrvbaHViY13ed/Ge3zBJr2Pyf2Wo9ixBDRiBXDsy+4dvCJnNksn/bzuZX8Uf+wxSmD6URqkEvq L55+E9OPJ33QNIjH9OXkrZGNieiSGay4di4PTW9LuY/O5BiKQHJVAry3yo1xL5sDvKqlHnjReDsP5 q5RQ8UunVJc5ch05lyANmpklQdzQg0jLchAntsu7SxpReAe0UXAwdlXgibTR59KrWb5IKN6WBgNKj iQkosV55q2sJoGuDCNX8YEHLSOtZmH0fBMtGiD0dLINZx+ruuSOqP/98LlevPPuW5Pn1EKwMAlyqy 42cWERlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJVIg-0000000ECOy-1yl0; Tue, 18 Jun 2024 09:38:50 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJVIZ-0000000ECLh-1A4p for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2024 09:38:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718703523; x=1750239523; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=QenCB3euq69QSB//DNTS+Hjnrm1i70bry2vnqFA0Xns=; b=Tf2bUpfgYD30Vy7LbE25Dz4q+35fExpSDsxkNnGahEDEGOT94xuQsjJE CGC89dVPzjXMVOHXtlTx5U3ofaDLjZ8bqeef01oFynEYfLypwLRwNVKYg ZbdXFrYNBu4nLJanQqzScZbvxGkCgfY7bgiTVnuhqWpMKMsV8GmVi0HJU ru5wfB1DawHI6B48PNRz4S+CUic8BP1U3lzVo5h887ZQamRfv1uclOxx8 +oSbCUfKS3xzOXyk8xBs4tbvLxAHvZynPXCEIlHxDtHCyyFJ6cSST1Yqi sa4+2EZvWAqQXW6+MGEflaIkYmIwiGSdqqx1ueyIJsuon3CLDtH8sA5sF w==; X-CSE-ConnectionGUID: VcwOlF/jQXyYWBjkKN2jRQ== X-CSE-MsgGUID: VXWVuRnlQBanzzwcbzZCWQ== X-IronPort-AV: E=McAfee;i="6700,10204,11106"; a="40973752" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="40973752" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 02:38:39 -0700 X-CSE-ConnectionGUID: 8q3IjEVeRvOFZ8qUIH04zg== X-CSE-MsgGUID: w6BdYPq0TguAHoQ8bDknCg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="64724227" Received: from bergbenj-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.176]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 02:38:29 -0700 From: Jani Nikula To: =?utf-8?Q?Andr=C3=A9?= Almeida , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Dmitry Baryshkov Subject: Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration In-Reply-To: <20240618030024.500532-3-andrealmeid@igalia.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240618030024.500532-1-andrealmeid@igalia.com> <20240618030024.500532-3-andrealmeid@igalia.com> Date: Tue, 18 Jun 2024 12:38:26 +0300 Message-ID: <878qz2h9pp.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240618_023843_344323_4C6621AD X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , 'Marek =?utf-8?B?T2zFocOhayc=?= , Claudiu Beznea , =?utf-8?Q?And?= =?utf-8?Q?r=C3=A9?= Almeida , Sam Ravnborg , ville.syrjala@linux.intel.com, Karol Herbst , Michel =?utf-8?Q?D=C3=A4nzer?= , Dave Airlie , Daniel Stone , kernel-dev@igalia.com, Lyude Paul , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , Melissa Wen , Pekka Paalanen , Rodrigo Vivi , Boris Brezillon , Simon Ser , Xaver Hugl , daniel@ffwll.ch, alexander.deucher@amd.com, christian.koenig@amd.com, Joshua Ashton Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Jun 2024, Andr=C3=A9 Almeida wrote: > Drivers have different capabilities on what plane types they can or > cannot perform async flips. Create a plane::async_flip field so each > driver can choose which planes they allow doing async flips. > > Signed-off-by: Andr=C3=A9 Almeida > --- > include/drm/drm_plane.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h > index 9507542121fa..0bebc72af5c3 100644 > --- a/include/drm/drm_plane.h > +++ b/include/drm/drm_plane.h > @@ -786,6 +786,11 @@ struct drm_plane { > * @kmsg_panic: Used to register a panic notifier for this plane > */ > struct kmsg_dumper kmsg_panic; > + > + /** > + * @async_flip: indicates if a plane can do async flips > + */ When is it okay to set or change the value of this member? If you don't document it, people will find creative uses for this. BR, Jani. > + bool async_flip; > }; >=20=20 > #define obj_to_plane(x) container_of(x, struct drm_plane, base) --=20 Jani Nikula, Intel