From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E59EC433F5 for ; Tue, 10 May 2022 18:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JURvV3QeHxdQjlJ5gBxkCYDJU1H1oq09i8uH/EXui+s=; b=dn/Id21+iLhk1c Qs/QTNx7NbWpzqPwsqFX3wsx0ysCaOOBf/Ys6J6IqRIp2cvyLSal8dQZ0Nb7wi5JcJ+Dc8HawCM+l hXGjAc18h//u8gwsEgNXWVVgS0NCf9XGzGBlIyUMxoGld1zcy7cP1EYsT4Pyp6mYBxjK84BH0Zxoi xpg9Tw6wYKShysKBbNVVFj2ckPEiJEjw5N08ynIzoE/k4hiGqZ8ZIQhi625n7JnFxMUHobgYSDuU4 Qz/gHfR3KxUVoJbAvpiK6IaiDg7x8DLZwf2ShBuI/+SU+1RwCba3zRHvUKe2t8+3Lsh2BVtXsmeXc pEvOKZFE3FWoKxZKNDSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noUgZ-003eKi-B3; Tue, 10 May 2022 18:34:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noUgW-003eK0-9k for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 18:34:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 327B360E71; Tue, 10 May 2022 18:34:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 891D5C385A6; Tue, 10 May 2022 18:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652207650; bh=8yNzAfOxKFZjkAMggfSelhh2GARAvKpSF0xNSpEDIYQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uEbrKQQUdFIkbepPMbyCL5JcorARGDdFN/pGDV2EptjjyxY52drl7gqNLDaBmPzvy uaxpsr+uSrY3Va8lvMv/TUElgH35cZfQe4SGaB139Q8YeTAvpKLhzFRWw0+vsFxHlX M2lw1r4k1DCK7wjyIL3an42g2Tq95J6l7dA2rzo0WPd+wU0Ea1CJLonEu71LW04+3U zjtbjzhkfAj7OJqoQK4udAZBwSnSiPJjm0MOjC2iSbMLnaA90txP1u9is58XfrApI1 QdCrvHc87vjE74GU0hMPlTvZkUtXqWGfkovccLqiH+fgrBL1MW4b45NgrQWg0CwBWB qcpTc03zcPOxQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1noUgR-00AMpf-QB; Tue, 10 May 2022 19:34:07 +0100 Date: Tue, 10 May 2022 19:34:07 +0100 Message-ID: <878rr96xuo.wl-maz@kernel.org> From: Marc Zyngier To: Antonio Borneo Cc: Thomas Gleixner , Maxime Coquelin , Alexandre Torgue , , , , Ludovic Barre , Loic Pallardy , Pascal Paillet Subject: Re: [PATCH 1/7] irqchip/stm32-exti: set_affinity return IRQ_SET_MASK_OK_DONE if no parent In-Reply-To: <20220510164123.557921-1-antonio.borneo@foss.st.com> References: <20220510164123.557921-1-antonio.borneo@foss.st.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: antonio.borneo@foss.st.com, tglx@linutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ludovic.barre@foss.st.com, loic.pallardy@foss.st.com, p.paillet@foss.st.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_113412_456982_B0DA0F90 X-CRM114-Status: GOOD ( 24.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Antonio, On Tue, 10 May 2022 17:41:17 +0100, Antonio Borneo wrote: > > From: Ludovic Barre > > If no parent, there is no specific action to do in > stm32 irqchip, and so return IRQ_SET_MASK_OK_DONE. > > Signed-off-by: Ludovic Barre > Signed-off-by: Antonio Borneo > --- > drivers/irqchip/irq-stm32-exti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c > index 9d18f47040eb..10c9c742c216 100644 > --- a/drivers/irqchip/irq-stm32-exti.c > +++ b/drivers/irqchip/irq-stm32-exti.c > @@ -614,7 +614,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d, > if (d->parent_data->chip) > return irq_chip_set_affinity_parent(d, dest, force); > > - return -EINVAL; > + return IRQ_SET_MASK_OK_DONE; > } > > static int __maybe_unused stm32_exti_h_suspend(void) Can you *please* use a cover-letter when sending more that a single patch? I expect there is an overarching motive to this series. Where is it described? Also, please look at the way the subject lines are written for most irqchip patches: irqchip/foo: Frobify the bar callback return value Note the capital letter after the ':', and the fact that it starts with a verb. Here, I would have liked to see: irqchip/stm32-exti: Fix set_affinity() return value and leave the meat of the description to the commit log (instead of saying the exact same thing twice). Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel