From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rosen Penev <rosenp@gmail.com>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan
Date: Fri, 29 Jan 2021 16:27:50 +0100 [thread overview]
Message-ID: <878s8bu5jd.fsf@BL-laptop> (raw)
In-Reply-To: <20201203022321.19952-2-rosenp@gmail.com>
Hi Rosen,
> Split up the pins for each fan. This is needed in order to control them
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-388-helios4.dts | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
> index 5a6af7e83e44..ec134e22bae3 100644
> --- a/arch/arm/boot/dts/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/armada-388-helios4.dts
> @@ -127,11 +127,15 @@
> fan1: j10-pwm {
> compatible = "pwm-fan";
> pwms = <&gpio1 9 40000>; /* Target freq:25 kHz */
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_fan1_pins>;
> };
>
> fan2: j17-pwm {
> compatible = "pwm-fan";
> pwms = <&gpio1 23 40000>; /* Target freq:25 kHz */
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_fan2_pins>;
> };
>
> usb2_phy: usb2-phy {
> @@ -302,9 +306,12 @@
> "mpp54";
> marvell,function = "gpio";
> };
> - helios_fan_pins: helios-fan-pins {
> - marvell,pins = "mpp41", "mpp43",
> - "mpp48", "mpp55";
> + helios_fan1_pins: helios_fan1_pins {
> + marvell,pins = "mpp41", "mpp43";
> + marvell,function = "gpio";
> + };
> + helios_fan2_pins: helios_fan2_pins {
> + marvell,pins = "mpp48", "mpp55";
> marvell,function = "gpio";
> };
> microsom_spi1_cs_pins: spi1-cs-pins {
> --
> 2.17.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-29 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 2:23 [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Rosen Penev
2020-12-03 2:23 ` [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan Rosen Penev
2021-01-29 15:27 ` Gregory CLEMENT [this message]
2021-01-29 15:27 ` [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s8bu5jd.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox