From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE88AC43461 for ; Sat, 5 Sep 2020 09:28:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E9EF206A5 for ; Sat, 5 Sep 2020 09:28:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OnxfxId1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fENLhbl6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E9EF206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WLlqglH+eMDEAHsub/3cNXmDRynXbvkrOwO7apYm/xY=; b=OnxfxId1M1JNK0zPjlIn63+JL 0F+6cgx5obl5uD1gCOnV4HPufznD1JaryrGvl2C3VbiKqdy4aFjUe507ivL9x7sbWTYjnhpbBgZ7n 66TdqVEBC1hUZwQlepibXXxymreqy/7pXzLRubZ/u6jyGpb4TXOlsLF4T5AkOo/sgSplCh8RygVoS wSjBYBZc74AZh+rKcBkjNtMEJUoaI+QV5XBjKNLmBImD/lMpTZZSMml/XKwUD0HZyi/OD+EyKNKUT PIAK8Rldwz3V5tl9cKfIVm9IhPSO+O+vnHjYqCAyZpfixgzp0CRyHFx3II25mhwDbS8nEkQabZuBG DBnFkKfbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEUTC-0008VQ-3x; Sat, 05 Sep 2020 09:26:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEUT8-0008Uw-WD for linux-arm-kernel@lists.infradead.org; Sat, 05 Sep 2020 09:26:47 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6BA72074D; Sat, 5 Sep 2020 09:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599298005; bh=+ezArp0Mamo42Sub1yNL7kJYleMMNAOOe6LKTy4sgDA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fENLhbl67GGyW+NF0HoaCKwXUKFlVytSUYB/S73xmr+joXH3DSAk9tOKaD6o3lQ+/ Ze/8Zlifu1te4Ri/q8GITddFkxykxTdzYP6h1PorVhsdN5zVL8/aujqI/VwdMdARhI nA+kUTxEjq8dtPmF5WQ6b9svgYDi69P8/KyXyrOI= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEUT4-009LMf-No; Sat, 05 Sep 2020 10:26:42 +0100 Date: Sat, 05 Sep 2020 10:26:33 +0100 Message-ID: <878sdomv5i.wl-maz@kernel.org> From: Marc Zyngier To: Valentin Schneider Subject: Re: [PATCH v2 1/4] genirq: Walk the irq_data hierarchy when resending an interrupt In-Reply-To: References: <20200903183206.104838-1-maz@kernel.org> <20200903183206.104838-2-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net, tglx@linutronix.de, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200905_052647_099515_7B79E828 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Valentin, On Fri, 04 Sep 2020 20:28:38 +0100, Valentin Schneider wrote: > > > Hi Marc, > > On 03/09/20 19:32, Marc Zyngier wrote: > > On resending an interrupt, we only check the topmost irqchip for > > a irq_retrigger callback. However, this callback could be implemented > > at a lower level. Use irq_chip_retrigger_hierarchy() in this case. > > > > Rookie wording question here; re-reading this I'm questioning which way is > up. > > From an irq_data hierarchy PoV, the topmost chip (i.e. last ->parent) > should be the root irqchip. However, the irq_desc we get from irq_to_desc() > ought to hold the irq_data for the lowermost irqchip in that irq_data > hierarchy. > > Is it that here by "topmost" you instead mean topmost of the irqchip stack > on top of the root (IOW furthest away from the root)? That's indeed what I mean, but I agree that the terminology is confusing, and often used inconsistently (by me included). Maybe considering the irqchip stack along a vertical axis is the wrong thing to do, and that looking at it as a volume would be marginally better? How about innermost (close to the CPU) vs outermost (close to the device)? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel