Re: [PATCH v7 00/27] KVM: arm64: SVE guest support

Alex Bennée
2019-04-25T10:33:17Z

Dave Martin <Dave.Martin@arm.com> writes:

> This series implements support for allowing KVM guests to use the Arm
> Scalable Vector Extension (SVE), superseding the previous v6 series [1].
>
> The patches are also available on a branch for reviewer convenience. [2]
>
> The patches are based on v5.1-rc2.
>
> This series addresses a couple of minor review comments received on v6
> and otherwise applies reviewer tags only. The code differences
> between v6 and this series consist of minor cosmetic fixups only.
>
> Draft kvmtool patches were posted separately [3], [4].
>
> For a description of minor updates, see the individual patches.
>
>
> Thanks go to Julien Thierry and Julian Grall for their review efforts,
> and to Zhang Lei for testing the series -- many thanks for their help
> in getting the series to this point!
>
>
> Reviewers' attention is drawn to the following patches, which have no
> Reviewed-by/Acked-by. Please take a look if you have a moment.
>
> * Patch 11 (KVM: arm64: Support runtime sysreg visibility filtering)
>
> Previously Reviewed-by Julien Thierry, but this version of the
> patch contains some minor rework suggested by Mark Rutland during
> the v5 review [5].
>
> * Patch 15 (KVM: arm64: Add missing #include of <linux/string.h>
> in guest.c)
>
> (Trivial patch.)
>
> * Patch 26: (KVM: Document errors for KVM_GET_ONE_REG and
> KVM_SET_ONE_REG)
>
> (Documentation only.)
>
> * Patch 27: KVM: arm64/sve: Document KVM API extensions for SVE
>
> (Documentation only.)

I've finished going through the series. Aside from a few minor nits and
the discussion you've already had with drew happy with it. Have a
general:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

for the mail record...
>
> Known issues: none
>
>
> Testing status:
>
> * Lightweight testing on the Arm Fast Model, primarily to exercise the
> new vcpu finalization API.
>
> Ran sve-stress testing for several days on v6 on the Arm Fast Model,
> with no errors observed.

Once we have VHE support in QEMU I intend to give it a bit more testing.

--
Alex Bennée