Re: [PATCH v7 00/27] KVM: arm64: SVE guest support

Dave Martin
2019-03-29T15:07:02Z

On Fri, Mar 29, 2019 at 02:56:36PM +0000, Marc Zyngier wrote:
> Hi Dave,
>
> On 29/03/2019 13:00, Dave Martin wrote:
> > This series implements support for allowing KVM guests to use the Arm
> > Scalable Vector Extension (SVE), superseding the previous v6 series [1].
> >
> > The patches are also available on a branch for reviewer convenience. [2]
> >
> > The patches are based on v5.1-rc2.
> >
> > This series addresses a couple of minor review comments received on v6
> > and otherwise applies reviewer tags only. The code differences
> > between v6 and this series consist of minor cosmetic fixups only.
> >
> > Draft kvmtool patches were posted separately [3], [4].
> >
> > For a description of minor updates, see the individual patches.
> >
> >
> > Thanks go to Julien Thierry and Julian Grall for their review efforts,
> > and to Zhang Lei for testing the series -- many thanks for their help
> > in getting the series to this point!
> >
> >
> > Reviewers' attention is drawn to the following patches, which have no
> > Reviewed-by/Acked-by. Please take a look if you have a moment.
> >
> > * Patch 11 (KVM: arm64: Support runtime sysreg visibility filtering)
> >
> > Previously Reviewed-by Julien Thierry, but this version of the
> > patch contains some minor rework suggested by Mark Rutland during
> > the v5 review [5].
> >
> > * Patch 15 (KVM: arm64: Add missing #include of <linux/string.h>
> > in guest.c)
> >
> > (Trivial patch.)
> >
> > * Patch 26: (KVM: Document errors for KVM_GET_ONE_REG and
> > KVM_SET_ONE_REG)
> >
> > (Documentation only.)
> >
> > * Patch 27: KVM: arm64/sve: Document KVM API extensions for SVE
> >
> > (Documentation only.)
>
> In order to get people to test this a bit more, I've now pushed this
> series into -next. I'm pretty confident that it won't break a thing, but
> better safe than sorry. I also expect any fix to be pushed on top of
> this series.
>
> This doesn't mean that the review is over, quite the opposite. I intend
> to go over it once more, and I'd like other people to do the same
> (specially anyone looking at implementing the required support in QEMU).

Agreed, thanks for pushing it to next.

I'll continue testing and await further review from people.

Cheers
---Dave