From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE0FC10F14 for ; Sun, 21 Apr 2019 17:23:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FAE72080D for ; Sun, 21 Apr 2019 17:23:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KJzN0AZZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FAE72080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8yyyNVMDdKG8adaf5hgWa+Cl1A215l9kFp3MgDyvclc=; b=KJzN0AZZjeHgLo 35KdLvToLFGVlC5sYl/6wnxgjKh0t1kQB0u1zZU3Qgo1CL88megRGcWr1IOj2VnH8lt2Y+8zjUgcx 46FLG3y7aVr5bgGrREWKD2fGFKTTmEDpb9kJPwz5RcRQNCb/lPzMQGXIYmAA+xhOgzRyXoBGz7U/j v/CGJXjSOnqj3o+5dQKwR5G4l8d67s+TnjI0IA/1RLooNiYPSXTu+3UlYjuurT2Ffk9KD1YrBPgil BuhHKashEg02P19I5d6W1CxkjzP0efKp5VKYzuNny9iZBCtooa4YOsCdyuBJzNPX4iBR6Y03qQOMs afTqFZKzTtVBwtJmddnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIGBg-0006d0-D6; Sun, 21 Apr 2019 17:23:32 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIGBc-0006MX-Jf for linux-arm-kernel@lists.infradead.org; Sun, 21 Apr 2019 17:23:30 +0000 X-Originating-IP: 93.23.249.69 Received: from localhost (69.249.23.93.rev.sfr.net [93.23.249.69]) (Authenticated sender: gregory.clement@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 60455240010; Sun, 21 Apr 2019 17:23:12 +0000 (UTC) From: Gregory CLEMENT To: Nicholas Mc Guire , Jason Cooper Subject: Re: [PATCH 2/3] ARM: mvebu: drop return from void function In-Reply-To: <1555217391-3552-2-git-send-email-hofrat@osadl.org> References: <1555217391-3552-1-git-send-email-hofrat@osadl.org> <1555217391-3552-2-git-send-email-hofrat@osadl.org> Date: Sun, 21 Apr 2019 19:23:11 +0200 Message-ID: <878sw38e80.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190421_102328_805056_665852B1 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-kernel@vger.kernel.org, Russell King , Nicholas Mc Guire , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicholas, > The return statement is unnecessary here - so drop it. > > Signed-off-by: Nicholas Mc Guire Applied on mvebu/arm Thanks, Gregory > --- > > Problem reported by checkpatch > > WARNING: void function return statements are not generally useful > #141: FILE: arch/arm/mach-mvebu/board-v7.c:141: > + return; > +} > > Patch was compile-tested: mvebu_v7_defconfig (implies MACH_MVEBU_ANY=y) > (with some unrelated sparse warnings about missing syscalls) > > Patch is against 5.1-rc4 (localversion-next is 20190412) > > arch/arm/mach-mvebu/board-v7.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c > index 37f8cb6..28fd256 100644 > --- a/arch/arm/mach-mvebu/board-v7.c > +++ b/arch/arm/mach-mvebu/board-v7.c > @@ -137,7 +137,6 @@ static void __init i2c_quirk(void) > > of_update_property(np, new_compat); > } > - return; > } > > static void __init mvebu_dt_init(void) > -- > 2.1.4 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel