From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A9CDC43381 for ; Tue, 5 Mar 2019 10:31:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD9432082C for ; Tue, 5 Mar 2019 10:31:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZWvEkIkD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD9432082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TTZKVAV6LHYRLennr7lbhyp99EdsHlb+CI988usSPpw=; b=ZWvEkIkDvznATM 8E3HDHR2WA5b9Rk2Wt9ymZiRWjUf1LuOg3uQgDY8yobGqBHzUamBzragJtQZ78YjPAUVgDE6mFTcT jD1ok5rglEoQ5iIj8UC+aF38tCR7z7dFwHvi5hYteavrr3iJg/L3dA77s36IRcg7sVl6tuPJ93Kr/ FOWua+Si9Zqe2Fb6mordCc/X266+rvCSABtc4BoBxG3llgCK4CtzrLknurFOI2LSzRpC8rlwJJ5cQ W3i8I1vEPS8UmS9hXSesJN73/pLgX+Lc6muTqnqrqcB+6cIw63Q3i6cmhf39/xwuHafVlmkqc80Om x5goEZqmhXBq9MyZSiwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h17M8-0003vz-UU; Tue, 05 Mar 2019 10:31:28 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h17M5-0003rQ-Ep for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 10:31:27 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 02:31:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,443,1544515200"; d="scan'208";a="152161691" Received: from mcaron-mobl.ger.corp.intel.com (HELO localhost) ([10.252.56.153]) by fmsmga001.fm.intel.com with ESMTP; 05 Mar 2019 02:31:20 -0800 From: Jani Nikula To: Maxime Ripard Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data In-Reply-To: <20190305080848.jifr5rgcz2rejlz5@flea> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> <87imwymyki.fsf@intel.com> <20190305080848.jifr5rgcz2rejlz5@flea> Date: Tue, 05 Mar 2019 12:33:31 +0200 Message-ID: <878sxtd30k.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_023125_508163_478086FA X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , Maarten Lankhorst , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 05 Mar 2019, Maxime Ripard wrote: > On Mon, Mar 04, 2019 at 05:47:09PM +0200, Jani Nikula wrote: >> On Mon, 04 Mar 2019, Maxime Ripard wrote: >> > In some cases, in order to accomodate with displays with poor EDIDs, we >> > need to ignore that the monitor alledgedly supports audio output and >> > disable the audio output. >> >> *sad trombone* >> >> Trying to figure this out automatically in kernel is better than a >> quirk. >> >> A quirk is better than requiring the user to provide an override EDID >> via the firmware loader (drm.edid_firmware parameter). >> >> Requiring an override EDID is better than adding a module parameter. >> >> I'd much rather we exhausted the other options before adding module >> parameters to address specific issues with EDIDs. That's a rabbit hole >> with no end. > > We should also consider the usability of these solutions. > > Sure, the quirks are the ideal solution long term, but do we really > expect the average user that just got its device from Amazon and > connected it to its display to figure out: > > - That if it's display doesn't work, it's because the display is > broken > - That it is broken due to poor EDIDs > - To find out that it's supposed to be handled in DRM through a quirk > - How to make such a quirk > - How to recompile the kernel on its distro of choice > - That they need to send a patch later on to upstream Linux, and then > wait for a year or so (depending on their distro) before it's > actually working. > > Chances are that they would stop at 1, call the device trash and never > submit any quirk, therefore making the quirk approach useless in the > process. It only takes one user to reach the end of the list, and have the quirk figured out and backported to stable kernels, fixing it for the rest of the average users. Adding this to drm core means *I* will also have to care about this for i915 users that find ways to abuse this for whatever reason. And they *will* find ways, because hey, someone on some forum wrote that this fixed their issue on some random other machine. We've added too many driver specific debug knobs as module parameters over the years, and a good portion of the bug reports we get about basically anything come with a combination of random module parameters, some of which have ceased to exist years ago. People just copy-paste them from forums and wikis. Looking at [1], I'm sure it didn't start out that massive either. It was probably a knob or two, as a quick fix for the problem at hand, and then it was easy to add more. What looks like the easy route now really isn't. BR, Jani. [1] https://www.raspberrypi.org/documentation/configuration/config-txt/video.md -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel