linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kvalo@codeaurora.org (Kalle Valo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi
Date: Thu, 05 Oct 2017 09:58:01 +0300	[thread overview]
Message-ID: <878tgq5beu.fsf@codeaurora.org> (raw)
In-Reply-To: <C4895259-FCDE-4B21-BB15-8F150FC53BE3@aosc.io> (Icenowy Zheng's message of "Wed, 04 Oct 2017 18:15:11 +0800")

Icenowy Zheng <icenowy@aosc.io> writes:

> ? 2017?10?4? GMT+08:00 ??6:11:45, Maxime Ripard
> <maxime.ripard@free-electrons.com> ??:
>>On Wed, Oct 04, 2017 at 10:02:48AM +0000, Arend van Spriel wrote:
>>> On 10/4/2017 11:03 AM, Icenowy Zheng wrote:
>>> > 
>>> > 
>>> > ? 2017?10?4? GMT+08:00 ??5:02:17, Kalle Valo <kvalo@codeaurora.org>
>>??:
>>> > > Icenowy Zheng <icenowy@aosc.io> writes:
>>> > > 
>>> > > > Allwinner XR819 is a SDIO Wi-Fi chip, which has the
>>functionality to
>>> > > use
>>> > > > an out-of-band interrupt pin instead of SDIO in-band interrupt.
>>> > > > 
>>> > > > Add the device tree binding of this chip, in order to make it
>>> > > possible
>>> > > > to add this interrupt pin to device trees.
>>> > > > 
>>> > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> > > > Acked-by: Rob Herring <robh@kernel.org>
>>> > > > ---
>>> > > > Changes in v3:
>>> > > > - Renames the node name.
>>> > > > - Adds ACK from Rob.
>>> > > > Changes in v2:
>>> > > > - Removed status property in example.
>>> > > > - Added required property reg.
>>> > > > 
>>> > > >   .../bindings/net/wireless/allwinner,xr819.txt      | 38
>>> > > ++++++++++++++++++++++
>>> > > >   1 file changed, 38 insertions(+)
>>> > > >   create mode 100644
>>> > >
>>Documentation/devicetree/bindings/net/wireless/allwinner,xr819.txt
>>> > > 
>>> > > Like I asked already last time, AFAICS there is no upstream xr819
>>> > > wireless driver in drivers/net/wireless directory. Do we still
>>accept
>>> > > bindings like this for out-of-tree drivers?
>>> > 
>>> > See esp8089.
>>> > 
>>> > There's also no in-tree driver for it.
>>> 
>>> The question is whether we should. The above might be a precedent,
>>but it
>>> may not necessarily be the way to go. The commit message for esp8089
>>seems
>>> to hint that there is intent to have an in-tree driver:
>>> 
>>> """
>>>     Note that at this point there only is an out of tree driver for
>>this
>>>     hardware, there is no clear timeline / path for merging this.
>>Still
>>>     I believe it would be good to specify the binding for this in
>>tree
>>>     now, so that any future migration to an in tree driver will not
>>cause
>>>     compatiblity issues.
>>> 
>>>     Cc: Icenowy Zheng <icenowy@aosc.xyz>
>>>     Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>     Signed-off-by: Rob Herring <robh@kernel.org>
>>> """
>>> 
>>> Regardless the bindings are in principle independent of the kernel
>>and just
>>> describing hardware. I think there have been discussions to move the
>>> bindings to their own repository, but apparently it was decided
>>otherwise.
>>
>>Yeah, I guess especially how it could be merged with the cw1200 driver
>>would be very relevant to that commit log.
>
> The cw1200 driver seems to still have some legacy platform
> data. Maybe they should also be convert to DT.
> (Or maybe compatible = "allwinner,xr819" is enough, as
> xr819 is a specified variant of cw1200 family)

Ah, so the upstream cw1200 driver supports xr819? Has anyone tested
that? Or does cw1200 more changes than just adding the DT support?

-- 
Kalle Valo

  reply	other threads:[~2017-10-05  6:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 16:59 [PATCH v3 0/2] Allwinner XR819 SDIO Wi-Fi DT binding and OPi Zero XR819 IRQ Icenowy Zheng
2017-10-03 16:59 ` [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi Icenowy Zheng
2017-10-04  9:02   ` Kalle Valo
2017-10-04  9:03     ` Icenowy Zheng
2017-10-04 10:02       ` Arend van Spriel
2017-10-04 10:11         ` Maxime Ripard
2017-10-04 10:15           ` Icenowy Zheng
2017-10-05  6:58             ` Kalle Valo [this message]
2017-10-07 12:31               ` Icenowy Zheng
2017-10-07 13:01               ` icenowy at aosc.io
2017-10-14 12:00               ` icenowy at aosc.io
2017-10-16 12:58                 ` Kalle Valo
2017-10-03 16:59 ` [PATCH v3 2/2] ARM: sun8i: h2+: specify wifi interrupts for Orange Pi Zero Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tgq5beu.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).